Add unwrap_ok macro to replace unwrap in unit tests

The unwrap error message is not very useful.  This patch adds the
unwrap_ok macro that is basically the same as unwrap but prints a more
readable error message.

1 files changed, 16 insertions, 20 deletions

diff --git a/tests/device.rs b/tests/device.rs
index cd37869..67c2713 100644
--- a/tests/device.rs
+++ b/tests/device.rs
@@ -87,15 +87,13 @@ fn disconnect(device: DeviceWrapper) {
 
 #[test_device]
 fn get_serial_number(device: DeviceWrapper) {
-    let result = device.get_serial_number();
-    assert!(result.is_ok());
-    let serial_number = result.unwrap();
+    let serial_number = unwrap_ok!(device.get_serial_number());
     assert!(serial_number.is_ascii());
     assert!(serial_number.chars().all(|c| c.is_ascii_hexdigit()));
 }
 #[test_device]
 fn get_firmware_version(device: Pro) {
-    let version = device.get_firmware_version().unwrap();
+    let version = unwrap_ok!(device.get_firmware_version());
     assert_eq!(0, version.major);
     assert!(version.minor > 0);
 }
@@ -135,7 +133,7 @@ fn get_retry_count(device: DeviceWrapper) {
 
 #[test_device]
 fn config(device: DeviceWrapper) {
-    let admin = device.authenticate_admin(ADMIN_PASSWORD).unwrap();
+    let admin = unwrap_ok!(device.authenticate_admin(ADMIN_PASSWORD));
 
     let config = Config::new(None, None, None, true);
     assert_ok!((), admin.write_config(config));
@@ -274,12 +272,12 @@ fn assert_utf8_err_or_ne(left: &str, right: Result<String, Error>) {
 
 #[test_device]
 fn factory_reset(device: DeviceWrapper) {
-    let admin = device.authenticate_admin(ADMIN_PASSWORD).unwrap();
+    let admin = unwrap_ok!(device.authenticate_admin(ADMIN_PASSWORD));
     let otp_data = OtpSlotData::new(1, "test", "0123468790", OtpMode::SixDigits);
     assert_ok!((), admin.write_totp_slot(otp_data, 30));
 
     let device = admin.device();
-    let pws = device.get_password_safe(USER_PASSWORD).unwrap();
+    let pws = unwrap_ok!(device.get_password_safe(USER_PASSWORD));
     assert_ok!((), pws.write_slot(0, "test", "testlogin", "testpw"));
     drop(pws);
 
@@ -301,11 +299,11 @@ fn factory_reset(device: DeviceWrapper) {
 
     let device = device.authenticate_admin(ADMIN_PASSWORD).unwrap().device();
 
-    let user = device.authenticate_user(USER_PASSWORD).unwrap();
+    let user = unwrap_ok!(device.authenticate_user(USER_PASSWORD));
     assert_cmd_err!(CommandError::SlotNotProgrammed, user.get_totp_slot_name(1));
 
     let device = user.device();
-    let pws = device.get_password_safe(USER_PASSWORD).unwrap();
+    let pws = unwrap_ok!(device.get_password_safe(USER_PASSWORD));
     assert_utf8_err_or_ne("test", pws.get_slot_name(0));
     assert_utf8_err_or_ne("testlogin", pws.get_slot_login(0));
     assert_utf8_err_or_ne("testpw", pws.get_slot_password(0));
@@ -315,7 +313,7 @@ fn factory_reset(device: DeviceWrapper) {
 
 #[test_device]
 fn build_aes_key(device: DeviceWrapper) {
-    let pws = device.get_password_safe(USER_PASSWORD).unwrap();
+    let pws = unwrap_ok!(device.get_password_safe(USER_PASSWORD));
     assert_ok!((), pws.write_slot(0, "test", "testlogin", "testpw"));
     drop(pws);
 
@@ -327,7 +325,7 @@ fn build_aes_key(device: DeviceWrapper) {
 
     let device = device.authenticate_admin(ADMIN_PASSWORD).unwrap().device();
 
-    let pws = device.get_password_safe(USER_PASSWORD).unwrap();
+    let pws = unwrap_ok!(device.get_password_safe(USER_PASSWORD));
     assert_utf8_err_or_ne("test", pws.get_slot_name(0));
     assert_utf8_err_or_ne("testlogin", pws.get_slot_login(0));
     assert_utf8_err_or_ne("testpw", pws.get_slot_password(0));
@@ -406,10 +404,9 @@ fn lock(device: Storage) {
 #[test_device]
 fn set_unencrypted_volume_mode(device: Storage) {
     fn assert_mode(device: &Storage, mode: VolumeMode) {
-        let status = device.get_status();
-        assert!(status.is_ok());
+        let status = unwrap_ok!(device.get_status());
         assert_eq!(
-            status.unwrap().unencrypted_volume.read_only,
+            status.unencrypted_volume.read_only,
             mode == VolumeMode::ReadOnly
         );
     }
@@ -434,15 +431,14 @@ fn set_unencrypted_volume_mode(device: Storage) {
 
 #[test_device]
 fn get_storage_status(device: Storage) {
-    let status = device.get_status().unwrap();
-
+    let status = unwrap_ok!(device.get_status());
     assert!(status.serial_number_sd_card > 0);
     assert!(status.serial_number_smart_card > 0);
 }
 
 #[test_device]
 fn get_production_info(device: Storage) {
-    let info = device.get_production_info().unwrap();
+    let info = unwrap_ok!(device.get_production_info());
     assert_eq!(0, info.firmware_version.major);
     assert!(info.firmware_version.minor != 0);
     assert!(info.serial_number_cpu != 0);
@@ -455,7 +451,7 @@ fn get_production_info(device: Storage) {
     assert!(info.sd_card.oem != 0);
     assert!(info.sd_card.manufacturer != 0);
 
-    let status = device.get_status().unwrap();
+    let status = unwrap_ok!(device.get_status());
     assert_eq!(status.firmware_version, info.firmware_version);
     assert_eq!(status.serial_number_sd_card, info.sd_card.serial_number);
 }
@@ -469,12 +465,12 @@ fn clear_new_sd_card_warning(device: Storage) {
     // We have to perform an SD card operation to reset the new_sd_card_found field
     assert_ok!((), device.lock());
 
-    let status = device.get_status().unwrap();
+    let status = unwrap_ok!(device.get_status());
     assert!(status.new_sd_card_found);
 
     assert_ok!((), device.clear_new_sd_card_warning(ADMIN_PASSWORD));
 
-    let status = device.get_status().unwrap();
+    let status = unwrap_ok!(device.get_status());
     assert!(!status.new_sd_card_found);
 }