diff options
| author | Robin Krahl <robin.krahl@ireas.org> | 2019-01-27 23:23:00 +0000 |
|---|---|---|
| committer | Robin Krahl <robin.krahl@ireas.org> | 2019-01-27 23:23:00 +0000 |
| commit | c30cbd35ba187cd6e5055d3beb8420b11fb030ec (patch) | |
| tree | 60522f8d7c2230e7f04e3ec7f1f295d779a4a855 /CHANGELOG.md | |
| parent | d433189caefe6bd6c88da7fbb1d6e9304353eb83 (diff) | |
| download | nitrokey-rs-c30cbd35ba187cd6e5055d3beb8420b11fb030ec.tar.gz nitrokey-rs-c30cbd35ba187cd6e5055d3beb8420b11fb030ec.tar.bz2 | |
Always return a Result when communicating with a device
Previously, we sometimes returned a value without wrapping it in a
result if the API method did not indicate errors in the return value.
But we can detect errors using the NK_get_last_command_status function.
This patch changes the return types of these methods to Result<_, Error>
and adds error checks.
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 24c79af..25a8c31 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,6 +31,7 @@ SPDX-License-Identifier: MIT - Return `Error::Utf8Error` if libnitrokey returns an invalid UTF-8 string. - Implement `From<(T: Device, Error)>` for `Error`. - Fix timing issues with the `totp_no_pin` and `totp_pin` test cases. +- Always return a `Result` in functions that communicate with a device. # v0.3.4 (2019-01-20) - Fix authentication methods that assumed that `char` is signed. |