diff options
| author | Robin Krahl <robin.krahl@ireas.org> | 2020-01-29 13:52:19 +0100 |
|---|---|---|
| committer | Robin Krahl <robin.krahl@ireas.org> | 2020-02-03 10:22:13 +0100 |
| commit | c1f48ce6c614586042db8891d2eebf19d2212ce4 (patch) | |
| tree | 9824d4552faf18a09eabb214deb87b4db950ab41 /CHANGELOG.md | |
| parent | 4a9dab94400cb00ae1e28485ddc64d46cf27ed3c (diff) | |
| download | nitrokey-rs-c1f48ce6c614586042db8891d2eebf19d2212ce4.tar.gz nitrokey-rs-c1f48ce6c614586042db8891d2eebf19d2212ce4.tar.bz2 | |
Use NK_get_status to implement Device::get_config
libnitrokey’s NK_read_config function returns a pointer to an array that
has been allocated using new[]. We would have to delete this pointer
using delete[], but we only have access to free. Therefore this patch
modifies the Device::get_config function to call NK_get_status instead
of NK_read_config.
This also makes the code more safe as we get the data as a struct
instead of an array. It does not add much overhead as NK_read_config
also executes the GET_STATUS command on the Nitrokey device.
Diffstat (limited to 'CHANGELOG.md')
| -rw-r--r-- | CHANGELOG.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index f5bb7cb..c94e170 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,8 @@ SPDX-License-Identifier: CC0-1.0 _>` to `Result<u32, _>`. - Change the type of the field `DeviceInfo.serial_number` from `Option<String>` to `Option<u32>`. +- Use `NK_get_status` instead of `NK_read_config` to implement the + `Device::get_config` function. # v0.5.2 (2020-01-28) - Use `CString` to store the temporary password instead of `Vec<u8>`. |