diff options
| author | Robin Krahl <robin.krahl@ireas.org> | 2018-05-22 12:02:06 +0200 | 
|---|---|---|
| committer | Robin Krahl <robin.krahl@ireas.org> | 2018-05-22 12:02:06 +0200 | 
| commit | 105dcead4890bee529f4ae9833892cdd1a4f8014 (patch) | |
| tree | 21e2d608b0a382b78ced8900b2b0ef8801023d34 | |
| parent | 1cd68d3fccda7b6c80009b19ec9853681d9d15ae (diff) | |
| download | nitrokey-rs-105dcead4890bee529f4ae9833892cdd1a4f8014.tar.gz nitrokey-rs-105dcead4890bee529f4ae9833892cdd1a4f8014.tar.bz2 | |
Improve log level documentation
Now, the documentation clearly states the purpose of each log level.
Also, the documentation for set_log_level is corrected:  libnitrokey
always prints to stderr.
| -rw-r--r-- | TODO.md | 1 | ||||
| -rw-r--r-- | src/lib.rs | 3 | ||||
| -rw-r--r-- | src/util.rs | 19 | 
3 files changed, 12 insertions, 11 deletions
| @@ -36,7 +36,6 @@    - `NK_list_devices_by_cpuID`    - `NK_connect_with_ID`  - Fix timing issues with the `totp` and `totp_pin` test cases. -- Improve log level documentation.  - Clear passwords from memory.  - Find a nicer syntax for the `write_config` test.  - Fix segmentation faults when freeing string literals with old Nitrokey @@ -167,7 +167,8 @@ pub fn set_debug(state: bool) {  }  /// Sets the log level for libnitrokey.  All log messages are written to the -/// standard output or standard errror. +/// standard error stream.  Setting the log level enables all log messages on +/// the same or on a higher log level.  pub fn set_log_level(level: LogLevel) {      unsafe {          nitrokey_sys::NK_set_debug_level(level.into()); diff --git a/src/util.rs b/src/util.rs index 8a6c411..d380de4 100644 --- a/src/util.rs +++ b/src/util.rs @@ -48,22 +48,23 @@ pub enum CommandStatus {      Error(CommandError),  } -/// Log level for libnitrokey. +/// Log level for libnitrokey.  Setting the log level to a lower level enables +/// all output from higher levels too.  Currently, only the log levels `Warning`, +/// `DebugL1`, `Debug` and `DebugL2` are actually used.  #[derive(Debug, PartialEq)]  pub enum LogLevel { -    /// Only log error messages. +    /// Error messages.  Currently not used.      Error, -    /// Log error messages and warnings. +    /// Warning messages.      Warning, -    /// Log error messages, warnings and info messages. +    /// Informational messages.  Currently not used.      Info, -    /// Log error messages, warnings, info messages and debug messages. +    /// Basic debug messages, especially basic information on the sent and received packets.      DebugL1, -    /// Log error messages, warnings, info messages and detailed debug -    /// messages. +    /// Detailed debug messages, especially detailed information on the sent and received packets.      Debug, -    /// Log error messages, warnings, info messages and very detailed debug -    /// messages. +    /// Very detailed debug messages, especially detailed information about the control flow for +    /// device communication (for example function entries and exits).      DebugL2,  } | 
