aboutsummaryrefslogtreecommitdiff
path: root/st.c
Commit message (Collapse)AuthorAge
...
* Fix crash due to wide charactersRian Hunter2015-02-05
| | | | | | | | | In tputc(), when a character wasn't large enough to fit on the current line, we would call tnewline() to place it on the next line. Unfortunately, we weren't resetting our glyph pointer and this caused memory corruption when a wide character (width == 2) was being written. This patch resets our glyph pointer after calls to tnewline().
* Fix crash due to invalid timespec given to pselectIvan Delalande2014-12-23
| | | | | | | | | | If blinktimeout is set to a value greater than 1000, pselect will receive a timeout argument with tv_nsec greater than 1E9 (1 sec), and fail, making st crash. This patch just ensures that the timespec structure is correctly filled with a value properly decomposed between tv_sec and tv_nsec. Reported by JasonWoof on IRC. Thanks!
* Trim trailing whitespaces in every selection caseIvan Delalande2014-11-19
| | | | | | | | | Trailing whitespaces are trimmed when copying from normal selection and rectangular selection on lines that have their last character included or on the left of the selection. It leads to inconsistent behaviors when copying the exact same text from the left and right window in applications with vertical splits. This patch solves this issue by always trimming the selection.
* Call _exit() instead of exit() if exec*() failssin2014-11-19
| | | | | exit() will also unwind the atexit() functions. This is bad because if exec*() fails the process is in an inconsistent state.
* Check for presence of SHELL environment variableEric Pruitt2014-11-11
| | | | | | | | | - POSIX states the SHELL environment variable "... shall represent a pathname of the user's preferred command language interpreter." As such, st should check for its presence when deciding what shell to use; just as HOME can be defined to override one's passwd-defined home directory, a user should also be able to override their passwd-defined shell using the SHELL environment variable.
* Replace character with U+FFFD if wcwidth() is -1czarkoff@gmail.com2014-11-03
| | | | Helpful when new Unicode codepoints are not recognized by libc.
* Avoid failing when embedding with a Window id of 0Quentin Rameau2014-10-21
| | | | I'd like to let st run with its own window when trying to embed it to a window with id 0 instead of exiting with an error.
* Do not set SHELL to utmp everRoberto E. Vargas Caballero2014-10-15
| | | | | SHELL must be set to the SHELL of the user, but it was possible set it to utmp.
* patch for bell in stCustaiCo2014-10-13
| | | | | | | | | | | | | | | The XBell() call currently used when a bell is recieved sends a message to the X server, but if the X server doesn't know how to sound it, it just gets ignored and I have not been able to find anywhere in x.org's code a way to configure the action that the server does. However, if you use XkbBell() then you can have a process listening for the XkbBellNotifyEvent that is produced and either alert you visually or play an audio file or whatever you want as your notification. You have to include one more header file but the function seems to be compiled as part of Xlib, at least on my installation. CustaiCo
* Add LS2 and LS3Roberto E. Vargas Caballero2014-10-08
| | | | | These sequences are the equivalents of LS0 and LS1, but for G2 and G3.
* Fix SI and SORoberto E. Vargas Caballero2014-10-08
| | | | | | SI (0x0F or ^O) means Shift In, and it selects G1 charset definition, and SO (0x0E or ^N) means Shift Out, and it selects G0 charset definition, but st was doing just the inverse.
* Minor style changes for the last patch.Christoph Lohmann2014-09-29
|
* Implementing xzoomreset.Christoph Lohmann2014-09-29
| | | | Thanks mvdan@mvdan.cc for proposing this.
* Add missed names of charset sequencesRoberto E. Vargas Caballero2014-09-23
|
* Add support for utmp in stRoberto E. Vargas Caballero2014-09-23
| | | | | | | | | | | | | | | St runs an interactive shell and not a login shell, and it means that profile is not loaded. The default terminal configuration in some system is not the correct for st, but since profile is not loaded there is no way of getting a script configures the correct values. St doesn't update the utmp files, this is the job of another suckless tool, utmp. Utmp also opens a login shell (it is the logical behaviour when you create a new user record) it is a good option execute utmp and then get a correct input in utmp, wtmp and lastlog file, and execute the content of the profile.
* Remove indentation level in xdrawcursorRoberto E. Vargas Caballero2014-09-09
|
* Removing wrapping newlines from selectionBen Hendrickson2014-08-23
| | | | | | | | | | | | | | | | When getting selected text, lines that were wrapped because of length ought not include the wrapping newline in the selection. This comes up, for example, when copying a bash command that is long enough to wrap from the console and pasting it back into the console. The extra newline breaks it. Similiarly, changes behavior when trimming whitespace from the end of a physical line to only do so if the line does not wrap. Otherwise we are trimming whitespace from the middle of a logical line, which may change its meaning. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Change the behavior of word snapping on delimitersIvan Delalande2014-08-21
| | | | | | | | This makes any sequence of identical delimiters be considered a single word in word-snapping mode. This seems more coherent for this mode and is similar to what xterm does. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Move calls to selsnap into selnormalizeIvan Delalande2014-08-21
| | | | | | | | This simplifies getbuttoninfo() and bpress(), and fixes a bug which made word snapping behave incorrectly when a delimiter was at the beginning or end of line. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Improve readability of enum membersAlexander Huemer2014-08-20
| | | | | | | | The 'left shift from one' notation of power of two integers is more expressive than the result. Signed-off-by: Alexander Huemer <alexander.huemer@xx.vu> Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Add eschandle()Roberto E. Vargas Caballero2014-08-20
| | | | | | | We already have a csihandle() function, where is located code about CSI sequences, so it is logical do the same with ESC sequences. This change helps to simplify tcontrol(), which has a complex flow and should be rewritten.
* Improve execsh() and don't allow anonymous shellsRoberto E. Vargas Caballero2014-08-20
| | | | | This patch improves the shell selection on execsh and forbid shell with users don't registered in the passwd file.
* Fix definition of CONTROLC0Roberto E. Vargas Caballero2014-08-19
| | | | | | | DEL character is not thecnically talking a C0 control character, although it has some common properties with them, so it is useful for us consider it as C0. Before this patch DEL (\177), was not ignored as it ought to be.
* reset the alt screen in tresetQuentin Carbonneaux2014-08-19
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* simplify loop in tresizeQuentin Carbonneaux2014-08-19
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fix man page and usage()Roberto E. Vargas Caballero2014-08-17
| | | | | | Man page was repeating -f option, the second time instead of -i, and this option was lost in usage() message. This patch also indent the output of usage().
* Convert VT102ID to a config variableRoberto E. Vargas Caballero2014-08-15
| | | | | | VT102ID is the sequence that the terminal returns when it is inquired to identify itself. This value should be configurable in the same way that another st parameters.
* Fix portability problem in techo()Roberto E. Vargas Caballero2014-08-15
| | | | | | | | | | ISCONTROL chechks if a value is between 0 and 0x1f or between 0x80 and 0x9f. Char signess depends of architecture and compiler, so in some environment the second case is always false (and wrong), Techo() calls ISCONTROL with a char variable, whose type cannot be changed because tpuc() expects a pointer to char, so the solution is to insert a cast in the call to ISCONTROL.
* Don't set dirty all lines because tswapcreen do itnoname2014-08-10
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* tresize return value is not usednoname2014-08-10
| | | | Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Unset mode when clearing regionsRoberto E. Vargas Caballero2014-08-07
| | | | | | | | | | | | | | tclearregion() was clearing regions using spaces and the current attributes of the terminal. It was correct with all the modes excepct underline, because they didn't affect the space character, but in the case of underline it was a problem. A easy way of seeing this problem is writing this in the last line of the terminal: tput smul ; echo first; tput rmul; echo second; echo third Fist was underlined, and second and third were not underlined, but the spaces at the right of second was underlined becuause in the previous scrool underline mode was set.
* Add error message when child exits whit errorRoberto E. Vargas Caballero2014-08-04
| | | | | | Master proccess was not showing any error message when the child died with an error, and it was very confusing for the user (for example with incorrect -e command).
* Remove difference between fast and slow blinkingRoberto E. Vargas Caballero2014-07-31
| | | | | | | | | | One blinking mode is good enough, and two is too much. The best aproach is emulate the fast blinking with the slow blinking, that it is more used. It is removed the flag ATTR_FASTBLINK because it has not a different meaning of ATTR_BLINK, so it is not needed. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fix disabling of bold and fastblinkMichael Forney2014-07-26
| | | | | | | | | | | | | According to ECMA-48¹ 8.3.117, an attribute value of 21 is "doubly underlined", while 22 is "normal colour or normal intensity (neither bold nor faint)". Additionally, 25 is "steady (not blinking)", which likely means neither slow blink nor fast blink. ¹: http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Fix st with input method.Weng Xuetian2014-07-19
| | | | | | | XFilterEvent need to be called against every event, otherwise it would missing some message in the xim protocol and misbehave on some im server. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Changed inconsistent indentEric Pruitt2014-07-15
| | | | | | | - A line was indented using spaces despite the rest of the code using tabs. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Add 8 bit version of DCS, APC, PM, OSCRoberto E. Vargas Caballero2014-07-08
| | | | | DCS, APC, PM, OSC version for 7 bits environments already was implemented in st. This patch adds the 8 bit version of it.
* Add 8 bit version of HTSRoberto E. Vargas Caballero2014-07-08
| | | | | HTS version for 7 bits environments already was implemented in st. This patch adds the 8 bit version of it.
* Add 8 bit version of NELRoberto E. Vargas Caballero2014-07-08
| | | | | NEL version for 7 bits environments already was implemented in st. This patch adds the 8 bit version of it.
* Add 8 bit version of DECIDRoberto E. Vargas Caballero2014-07-08
| | | | | DECID version for 7 bits environments already was implemented in st. This patch adds the 8 bit version of it.
* Render faint attributeAnders Eurenius2014-07-08
| | | | | | | | | Faint text is implemented by allocating a new color at one-half intensity of each of the r, g, b components, or if the text bold at the same time, it is not made lighter. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com> Signed-off-by: Christoph Lohmann <20h@r-36.net>
* Remove all strcmp and strlen calls on Glyph.c[]Ivan Delalande2014-07-08
| | | | | | | | | | There were a few occurrences of strcmp and strlen being called on Glyph.c[], which is not always null-terminated (this actually depends on the last values in the buffer s in ttyread()). This patch replace all the calls to strcmp with a test on c[0] directly or a call to tlinelen, and the one to strlen with utf8len. I also took the opportunity to refactor getsel and tdumpline. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Render struck-out attributeAnders Eurenius2014-06-27
| | | | | | | | Implement crossed-out text with an XftDrawRect call, similar to how underline is implemented. The line is drawn at 2/3 of the font ascent, which seems to work nicely in practice. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Render invisible attributeAnders Eurenius2014-06-27
| | | | | | | | | Implement invisible mode by setting the foreground color to be the same as the background color. Not rendering anything would also be an alternative, but this seems less likely to cause surprises in conjunction with any hacks. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Reorder and extend glyph attributesAnders Eurenius2014-06-27
| | | | | | | | | | Faint, invisible, struck and fast blink are added as glyph attributes. Since there's an edit here, let's take the opportunity to reorder them so that they correspond to the two's power of the corresponding escape code. (just for neatness, let's hope that property never gets used for anything.) Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Remove CEIL macroRoberto E. Vargas Caballero2014-06-26
| | | | | | | | This macro was not correct in some cases, and it was used only in one place, where we did'nt get any benefit in performance of in size, so the macro is removed and ceilf is used instead of it. The only function needed from math.h is ceilf, so this patch defines the prototype of it instead of including math.h.
* Fixed wrong nanosecond factor 10E6.Ivan Delalande2014-06-26
| | | | | | | | | | Commit 5edeec1 introduced a wrong factor for nanosecond computation, the correct value is 1E6. Time and timeout values are 10 times less than they should be and this cause high CPU usage. Reported by pyroh on IRC. Thanks! Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Use monotonic clock to prevent timing issuesFRIGN2014-06-24
| | | | | | | | | | | | | | This patch replaces the gettimeofday()/timeval-system with uses of clock_gettime() with a monolithic clock and timespec-structs. gettimeofday() is not accurate and prone to jumps and POSIX.1-2008 marks it as obsolete. Read more here [0]. The patch should speak for itself and decreases the binary size for me by almost 200K(!). [0]: http://blog.habets.pp.se/2010/09/gettimeofday-should-never-be-used-to-measure-time Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* update size hints on zoomTroy Sankey2014-06-21
| | | | | | | On font zooming (i.e. xzoom()), window size hints are not updated. This patch does that. Signed-off-by: Roberto E. Vargas Caballero <k0ga@shike2.com>
* Refactor the innermost loop of the xdraws functionSilvan Jegen2014-06-15
| | | | | Signed-off-by: Silvan Jegen <s.jegen@gmail.com> Signed-off-by: Christoph Lohmann <20h@r-36.net>
generated by cgit v1.2.3 (git 2.46.0) at 2024-11-27 01:14:36 +0000