aboutsummaryrefslogtreecommitdiff
path: root/st.c
Commit message (Collapse)AuthorAge
* Update XIM cursor position only if changedIvan Tham2020-04-19
| | | | | Updating XIM cursor position is expensive, so only update it when cursor position changed.
* just remove the EOF messageHiltjo Posthuma2020-04-11
|
* Fix small typosHiltjo Posthuma2020-04-11
|
* Launch scroll program with the default shellQuentin Rameau2020-04-11
|
* Fix style issueRoberto E. Vargas Caballero2020-04-11
|
* ttyread: test for EOF while reading ttyRoberto E. Vargas Caballero2020-04-11
| | | | | | When a read operation returns 0 then it means that we arrived to the end of the file, and new reads will return 0 unless you do some other operation such as lseek(). This case happens with USB-232 adapters when they are unplugged.
* Add support for scroll(1)Roberto E. Vargas Caballero2020-04-11
| | | | | | | | | Scroll is a program that stores all the lines of its child and be used in st as a way of implementing scrollback. This solution is much better than implementing the scrollback in st itself because having a different program allows to use it in any other program without doing modifications to those programs.
* OSC 52 - copy to clipboard: don't limit to 382 bytesAvi Halachmi (:avih)2019-11-10
| | | | | | | | | | | | | | | | | | Strings which an application sends to the terminal in OSC, DCS, etc are typically small (title, colors, etc) but one exception is OSC 52 which copies text to the clipboard, and is used for instance by tmux. Previously st cropped these strings at 512 bytes, which for OSC 52 limited the copied text to 382 bytes (remaining buffer space before base64). This made it less useful than it can be. Now it's a dynamic growing buffer. It remains allocated after use, resets to 512 when a new string starts, or leaked on exit. Resetting/deallocating the buffer right after use (at strhandle) is possible with some more code, however, it doesn't always end up used, and to cover those cases too will require even more code, so resetting only on new string is good enough for now.
* CSIEscape, STREscape: use size_t for buffer lengthHiltjo Posthuma2019-11-10
|
* STREscape: don't trim prematurelyAvi Halachmi (:avih)2019-11-10
| | | | | | | | | | | STRescape holds strings in escape sequences such as OSC and DCS, and its buffer is 512 bytes. If the input is too big then trailing chars are ignored, but the test was off-by-1 such that it took 510 chars instead of 511 (before a terminating NULL is added). Now the full size can be utilized.
* base64dec: don't read out of boundsAvi Halachmi (:avih)2019-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously, base64dec checked terminating input '\0' every 4 calls to base64dec_getc, where the latter progressed one or more chars on each call, and could read past '\0' in the way it was used. The input to base64dec currently comes only from OSC 52 escape seq (copy to clipboard), and reading past '\0' or even past the buffer boundary was easy to trigger. Also, even if we could trust external input to be valid base64, there are different base64 standards, and not all of them require padding to 4 bytes blocks (using trailing '=' chars). It didn't affect short OSC 52 strings because the buffer is initialized to 0's, so typically it did stop within the buffer, but if the string was trimmed to fit (the buffer is 512 bytes) then it did also read past the end of the buffer, and the decoded suffix ended up arbitrary. This patch makes base64dec_getc not progress past '\0', and instead produce fake trailing padding of '='. Additionally, at base64dec, if padding is detected at the first or second byte of a quartet, then we identify it as invalid and abort (a valid quartet has at least two leading non-padding bytes).
* selection: fix view to match actual selection on first cellAvi Halachmi (:avih)2019-04-14
|
* revert part of commit add0211522737b79dad990ccd65c8af63b5cc1ddHiltjo Posthuma2019-03-15
| | | | | | | | | | "use iswspace()/iswpunct() to find word delimiters this inverts the configuration logic: you no longer provide a list of delimiters -- all space and punctuation characters are considered delimiters, unless listed in extrawordchars." Feedback from IRC and personal preference.
* dont print color warning on color reset OSC 104 without parameterHiltjo Posthuma2019-03-15
| | | | | | also print explicitly "(null)" when printf "%s" p=NULL. noticed when exiting mutt: printf '\x1b]104\x07'
* minor code-style, initialize var at the top of functionHiltjo Posthuma2019-03-15
|
* use iswspace()/iswpunct() to find word delimitersLauri Tirkkonen2019-03-15
| | | | | | this inverts the configuration logic: you no longer provide a list of delimiters -- all space and punctuation characters are considered delimiters, unless listed in extrawordchars.
* replace utf8strchr with wcschrLauri Tirkkonen2019-03-15
|
* be silent about explicitly unhandled mouse modesLauri Tirkkonen2019-03-13
|
* style: remove double empty newlinesHiltjo Posthuma2019-03-03
|
* better Input Method Editor (IME) supportIvan Tham2019-02-12
| | | | | | | | | | | | Features: - Allow input methods swap with hotkey (E.g. left ctrl + left shift). - Over-the-spot pre-editing style, pre-edit data placed over insertion point. - Restart IME without segmentation fault. TODO: - Automatically pickup IME if st started before IME
* output child WEXITSTATUS/WTERMSIG on abnormal terminationLauri Tirkkonen2018-12-11
|
* st: small typofix in commentHiltjo Posthuma2018-11-04
|
* small code-style fixHiltjo Posthuma2018-09-11
|
* Remove the ISO 14755 featureQuentin Rameau2018-09-11
| | | | | | And move it to the patches section. Keeping it would force to add an exec pledge on OpenBSD, and some people think it's bloated, so bye!
* code-style for pledge(2)Hiltjo Posthuma2018-05-25
| | | | feedback from Klemens, thanks
* Pledge on OpenBSDHiltjo Posthuma2018-05-25
|
* error message style and use strerror in a few placesHiltjo Posthuma2018-03-29
|
* set sel.alt in selstart instead of selextendDaniel Tameling2018-03-29
|
* selextend: clarify: !sel.mode == SEL_IDLEHiltjo Posthuma2018-03-17
|
* minor code-style: whitespace fixesHiltjo Posthuma2018-03-16
|
* regression: include termios.h for tcsendbreak etcHiltjo Posthuma2018-03-09
|
* General cleanupDevin J. Pohly2018-02-25
| | | | | | | Simplifies logic in a couple places and removes a redundant function call. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Clean up #includesDevin J. Pohly2018-02-25
| | | | Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Reduce visibility wherever possibleDevin J. Pohly2018-02-25
| | | | | | | | When possible, declare functions/variables static and move struct definitions out of headers. In order to allow utf8decode to become internal, use codepoint for DECSCUSR extension directly. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Limit usage of extern to config.h globalsDevin J. Pohly2018-02-25
| | | | | | | | Prefer passing arguments to declaring external global variables. The only remaining usage of extern is for config.h variables which are needed in st.c instead of x.c (where it is now included). Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Remove x.c dependency on termDevin J. Pohly2018-02-25
| | | | | | | | | | | The xinit function only needs to the rows/cols, so pass those in rather than accessing term directly. With a bit of arithmetic, we are able to avoid the need for term.row and term.col in x2col, y2row, and xdrawglyphfontspecs as well, completing the removal. Term is now fully internal to st.c. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Pull term references out of xdrawcursorDevin J. Pohly2018-02-25
| | | | | | | | | Gradually reducing x.c dependency on Term object. Old and new cursor glyph/position are passed to xdrawcursor. (There may be an opportunity to refactor further if we can unify "clear old cursor" and "draw new cursor" functionality.) Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move win-agnostic parts of draw/drawregion to st.cDevin J. Pohly2018-02-25
| | | | | | | | | | Introduces three functions to encapsulate X-specific behavior: * xdrawline: draws a portion of a single line (used by drawregion) * xbegindraw: called to prepare for drawing (will be useful for e.g. Wayland) and returns true if drawing should happen * xfinishdraw: called to finish drawing (used by draw) Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Split mode bits between Term and TermWindowDevin J. Pohly2018-02-25
| | | | | | | | | | | | | Moves the mode bits used by x.c from Term to TermWindow, absorbing UI/input-related mode bits (visible/focused/numlock) along the way. This is gradually reducing external references to Term. Since TermWindow is already internal to x.c, we add xsetmode() to allow st to modify window bits in accordance with escape sequences. IS_SET() is redefined accordingly (term.mode in st.c, win.mode in x.c). Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move CRLF input processing into ttywriteDevin J. Pohly2018-02-25
| | | | | | | | | This also allows us to remove the crlf field from the Key struct, since the only difference it made was converting "\r" to "\r\n" (which is now done automatically in ttywrite). In addition, MODE_CRLF is no longer referenced from x.c. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move terminal echo logic into st.cDevin J. Pohly2018-02-25
| | | | | | | The only thing differentiating ttywrite and ttysend was the potential for echo; make this a parameter and remove ttysend. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move remaining selection mode logic into selextendDevin J. Pohly2018-02-25
| | | | | | | The "done" parameter indicates a change which finalizes the selection (e.g. a mouse button release as opposed to motion). Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move terminal-related selection logic into st.cDevin J. Pohly2018-02-25
| | | | | | | | | | | The front-end determines information about mouse clicks and motion, and the terminal handles the actual selection start/extend/dirty logic by row and column. While we're in the neighborhood, we'll also rename getbuttoninfo() to mousesel() which is, at least, less wrong. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move X-specific selection info into XSelectionDevin J. Pohly2018-02-25
| | | | | | | Data about PRIMARY/CLIPBOARD and clicks are part of the front-end, not the terminal. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Have selected() check whether selection existsDevin J. Pohly2018-02-25
| | | | Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Rely on ttyresize to set tty sizeDevin J. Pohly2018-02-25
| | | | | | | | This removes ttynew's dependency on cresize being called first, and then allows us to absorb the ttyresize call into cresize (which always precedes it). Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Remove X and fontconfig from st.cDevin J. Pohly2018-02-25
| | | | | | | None of the X-related includes are needed any longer. In addition, move the X modifier defines into x.c, as they are not used outside. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Remove Time argument from xsetselDevin J. Pohly2018-02-25
| | | | | | | | | This is an X type and should be internal to x.c. The selcopy() function was a single line and only used in one place, so it was inlined to reduce LOC. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Make win variable internal to x.cDevin J. Pohly2018-02-25
| | | | | | | There was only a single reference to the `win` variable in st.c, so exporting that to x.c allows us to rid ourselves of another extern. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>
* Move config.h include from st.c to x.cDevin J. Pohly2018-02-25
| | | | | | | | config.h includes references to KeySyms and other X stuff. Until we come up with a cleaner way to separate configuration, it is simpler (leads to more code removal) to have this here. Signed-off-by: Devin J. Pohly <djpohly@gmail.com>