aboutsummaryrefslogtreecommitdiff
path: root/st.1
diff options
context:
space:
mode:
authormagras <dr.magras@gmail.com>2019-02-28 04:56:01 +0300
committerHiltjo Posthuma <hiltjo@codemadness.org>2019-03-03 11:18:31 +0100
commita8cb8e94547d7e31441d2444e8a196415e3e4c1f (patch)
treee21fe7c6c9dd86fe0b6982160f850499fec838db /st.1
parente85b6b64660214121164ea97fb098eaa4935f7db (diff)
downloadst-a8cb8e94547d7e31441d2444e8a196415e3e4c1f.tar.gz
st-a8cb8e94547d7e31441d2444e8a196415e3e4c1f.tar.bz2
fix use after free in font caching algorithm
Current font caching algorithm contains a use after free error. A font removed from `frc` might be still listed in `wx.specbuf`. It will lead to a crash inside `XftDrawGlyphFontSpec()`. Steps to reproduce: $ st -f 'Misc Tamsyn:scalable=false' $ curl https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt Of course, result depends on fonts installed on a system and fontconfig. In my case, I'm getting consistent segfaults with different fonts. I replaced a fixed array with a simple unbounded buffer with a constant growth rate. Cache starts with a capacity of 0, gets increments by 16, and never shrinks. On my machine after `cat UTF-8-demo.txt` buffer reaches a capacity of 192. During casual use capacity stays at 0.
Diffstat (limited to 'st.1')
0 files changed, 0 insertions, 0 deletions