Enable more lints

Given that development is picking up speed again we should accept all
the help we get from the compiler to catch issues as early as possible.
To that end, this change enables more lints for the program. As "usual",
lints that are suspected to potentially change in future versions of
Rust are reported as warnings and not errors.

3 files changed, 45 insertions, 1 deletions

diff --git a/nitrocli/CHANGELOG.md b/nitrocli/CHANGELOG.md
index 1a560b8..1b08bf3 100644
--- a/nitrocli/CHANGELOG.md
+++ b/nitrocli/CHANGELOG.md
@@ -3,6 +3,7 @@ Unreleased
 - Show PIN related errors through `pinentry` native reporting mechanism
   instead of emitting them to `stdout`
 - Adjusted program to use Rust Edition 2018
+- Enabled more lints
 - Applied a couple of `clippy` reported suggestions
 - Added categories to `Cargo.toml`
 - Changed dependency version requirements to be less strict (only up to
diff --git a/nitrocli/src/main.rs b/nitrocli/src/main.rs
index cfde9bd..23370ee 100644
--- a/nitrocli/src/main.rs
+++ b/nitrocli/src/main.rs
@@ -17,8 +17,50 @@
 // * along with this program.  If not, see <http://www.gnu.org/licenses/>. *
 // *************************************************************************
 
-#![deny(missing_docs)]
+#![deny(
+  dead_code,
+  duplicate_associated_type_bindings,
+  illegal_floating_point_literal_pattern,
+  improper_ctypes,
+  intra_doc_link_resolution_failure,
+  late_bound_lifetime_arguments,
+  missing_copy_implementations,
+  missing_debug_implementations,
+  missing_docs,
+  no_mangle_generic_items,
+  non_shorthand_field_patterns,
+  overflowing_literals,
+  path_statements,
+  patterns_in_fns_without_body,
+  plugin_as_library,
+  private_in_public,
+  proc_macro_derive_resolution_fallback,
+  safe_packed_borrows,
+  stable_features,
+  trivial_bounds,
+  trivial_numeric_casts,
+  type_alias_bounds,
+  tyvar_behind_raw_pointer,
+  unconditional_recursion,
+  unions_with_drop_fields,
+  unreachable_code,
+  unreachable_patterns,
+  unstable_features,
+  unstable_name_collisions,
+  unused,
+  unused_comparisons,
+  unused_import_braces,
+  unused_lifetimes,
+  unused_qualifications,
+  unused_results,
+  where_clauses_object_safety,
+  while_true,
+)]
 #![warn(
+  bad_style,
+  future_incompatible,
+  nonstandard_style,
+  renamed_and_removed_lints,
   rust_2018_compatibility,
   rust_2018_idioms,
 )]
diff --git a/nitrocli/src/pinentry.rs b/nitrocli/src/pinentry.rs
index b4695ec..1f1b02a 100644
--- a/nitrocli/src/pinentry.rs
+++ b/nitrocli/src/pinentry.rs
@@ -29,6 +29,7 @@ use crate::error::Error;
 #[derive(Clone, Copy, Debug, PartialEq)]
 pub enum PinType {
   /// The admin PIN.
+  #[allow(unused)]
   Admin,
   /// The user PIN.
   User,