Replace *out function parameter with return value

Using return value instead of memory manipulation seem to be cleaner solution and less error prone
due to avoiding pointer usage.

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>

1 files changed, 6 insertions, 9 deletions

diff --git a/unittest/test_C_API.cpp b/unittest/test_C_API.cpp
index f38d0b6..1964738 100644
--- a/unittest/test_C_API.cpp
+++ b/unittest/test_C_API.cpp
@@ -87,18 +87,15 @@ TEST_CASE("multiple devices with ID", "[BASIC]") {
 }
 
 TEST_CASE("Get device model", "[BASIC]") {
-    auto success = NK_get_device_model(nullptr);
-    REQUIRE(!success);
-
     NK_logout();
-    NK_device_model model = static_cast<NK_device_model>(3);
-    success = NK_get_device_model(&model);
-    REQUIRE(!success);
+    NK_device_model model = NK_get_device_model();
+    REQUIRE(model == NK_device_model::NK_DISCONNECTED);
 
-    auto result = NK_login_auto();
-    REQUIRE(result != 0);
-    success = NK_get_device_model(&model);
+    auto success = NK_login_auto() == 1;
     REQUIRE(success);
+    model = NK_get_device_model();
+    REQUIRE(model != NK_device_model::NK_DISCONNECTED);
+
     REQUIRE((model == NK_PRO || model == NK_STORAGE));
     NK_logout();
 }