diff options
| author | Szczepan Zalega <szczepan@nitrokey.com> | 2016-07-27 06:40:31 +0200 | 
|---|---|---|
| committer | Szczepan Zalega <szczepan@nitrokey.com> | 2016-08-01 13:54:57 +0200 | 
| commit | 37d833828746b2437479123866d5c54ae78e2b14 (patch) | |
| tree | 4842c66c04d6f15dbe6bce8c6c6da6651b6c51a0 | |
| parent | 33344655d519b351d17d4f166dba406d1ab79e8e (diff) | |
| download | libnitrokey-37d833828746b2437479123866d5c54ae78e2b14.tar.gz libnitrokey-37d833828746b2437479123866d5c54ae78e2b14.tar.bz2 | |
Remove auth from getPWSslotName does not need auth. Passing tests.
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
| -rw-r--r-- | NitrokeyManager.cc | 6 | ||||
| -rw-r--r-- | unittest/test_bindings.py | 4 | 
2 files changed, 3 insertions, 7 deletions
| diff --git a/NitrokeyManager.cc b/NitrokeyManager.cc index 2d63c21..4446d38 100644 --- a/NitrokeyManager.cc +++ b/NitrokeyManager.cc @@ -250,12 +250,6 @@ namespace nitrokey{          assert (is_valid_password_safe_slot_number(slot_number));          auto p = get_payload<GetPasswordSafeSlotName>();          p.slot_number = slot_number; - -        auto auth = get_payload<UserAuthorize>(); -        strcpyT(auth.temporary_password, temporary_password); -        auth.crc_to_authorize = GetPasswordSafeSlotName::CommandTransaction::getCRC(p); -        UserAuthorize::CommandTransaction::run(*device, auth); -          auto response = GetPasswordSafeSlotName::CommandTransaction::run(*device, p);          return strdup((const char *) response.slot_name);      } diff --git a/unittest/test_bindings.py b/unittest/test_bindings.py index 4bd7bb0..7632a5f 100644 --- a/unittest/test_bindings.py +++ b/unittest/test_bindings.py @@ -65,8 +65,10 @@ def test_write_password_safe_slot(C):  def test_get_password_safe_slot_name(C): +    assert C.NK_enable_password_safe(DefaultPasswords.USER) == DeviceErrorCode.STATUS_OK +    assert C.NK_write_password_safe_slot(0, 'slotname1', 'login1', 'pass1') == DeviceErrorCode.STATUS_OK      assert C.NK_lock_device() == DeviceErrorCode.STATUS_OK -    assert gs(C.NK_get_password_safe_slot_name(0, DefaultPasswords.ADMIN_TEMP)) == '' +    assert gs(C.NK_get_password_safe_slot_name(0, DefaultPasswords.USER_TEMP)) == ''      assert C.NK_get_last_command_status() == DeviceErrorCode.STATUS_NOT_AUTHORIZED      assert C.NK_enable_password_safe(DefaultPasswords.USER) == DeviceErrorCode.STATUS_OK | 
