experimental firmware for the Nitrokey Pro https://git.ireas.org/ntw/atom?h=master 2019-12-17T09:53:27Z 2019-12-17T09:53:27Z Robin Krahl robin.krahl@ireas.org 2019-12-17T09:52:02Z urn:sha1:a1a32b62c097689829dd96d828cc3c5e7a4a79e6 Our main function is unsafe as it uses the entry attribute. clippy requires a Safety section in the doc comment of public unsafe functions, but as we don’t have any documentation yet, we disable the clippy::missing_safety_doc lint. 2019-12-17T09:17:50Z Robin Krahl robin.krahl@ireas.org 2019-12-17T09:12:20Z urn:sha1:3c8f396f21dc75f733ef5eefe99afd0e9e798f40 Since static_assertions 1.0.0, we no longer have to specify a label when calling an assert macro. Therefore we can also remove the label from our own assert macro assert_maximum_size. 2019-12-17T09:17:44Z Robin Krahl robin.krahl@ireas.org 2019-12-17T09:09:24Z urn:sha1:5724b87a1c9fcf66e6205af6732fc07e4c9d909d This patch updates the static_assertions dependency to 1.1.0. This bumps the minimum supported Rust version to 1.37.0. As the labels have been removed in version 1.0.0, we can now call the assertion macros without an additional label. 2019-12-17T09:17:28Z Robin Krahl robin.krahl@ireas.org 2019-12-17T08:57:16Z urn:sha1:1dfd8694c6dfa31ba154456cd17ef2efe6bd7c7a This patch updates all dependencies to the newest versions (except static_assertions). It replaces the Git versions of stm32f103xx-usb and usb-device with crates.io versions of stm32-usbd (via stm32f1xx-hal) and usb-device. This bumps the minimum supported Rust version to 1.36.0 (for stm32-usbd). static_assertions is not updated as it would require an even newer Rust version. 2019-02-20T23:16:00Z Robin Krahl robin.krahl@ireas.org 2019-02-20T23:13:38Z urn:sha1:853e613769087a4bf67023e42f7fc4f3b92339fb There are different ways to implement the CRC check: For testing, we might want to calulate the CRC in the software. On STM32 MCUs, we want to use the CRC peripheral. This patch splits the struct Crc into the Crc trait and the Stm32Crc struct implementing Crc using the CRC peripheral. The Nitrokey struct can now accept any Crc implementation. 2019-02-20T13:09:40Z Robin Krahl robin.krahl@ireas.org 2019-02-20T12:31:45Z urn:sha1:4b436755d5895cb7113bee135d451cdeb2cf465a The request and response structs for a command should not be bigger than the buffer they are read from or written to. Therefore we add assertions that enforce this property at compile time. 2019-02-20T11:50:32Z Robin Krahl robin.krahl@ireas.org 2019-02-20T11:47:25Z urn:sha1:e0d33dae2f2ab70b936467590284030d759f9db7 The Request and Response types have to have a size of 64 bytes. Previously, we only verified this property by visual inspection. Accidental changes to the size could lead to runtime errors. This patch adds static assertions using the static_assertions crate to enforce this property at compile time. 2019-02-20T11:50:25Z Robin Krahl robin.krahl@ireas.org 2019-02-20T11:40:09Z urn:sha1:0d162c3d9e6a220fe30768bedcb129bf04a2cc7b To increase type safety, we use references to (sized) arrays instead of slices where possible. 2019-02-20T11:50:15Z Robin Krahl robin.krahl@ireas.org 2019-02-20T11:32:59Z urn:sha1:990063fb3ecfc6baeb51e4f57b3f75ee16bac56e Previously, we had the device::REQUEST_DATA_LEN constant for the size of the raw data in the request, and the commands::COMMAND_LEN constant for the size of the raw data in the response. This patch renames commands::COMMAND_LEN to device::RESPONSE_DATA_LEN for consistency. It also introduces the {Request,Response}Data type aliases for [u8; {REQUEST,RESPONSE}_DATA_LEN]. 2019-02-19T22:24:50Z Robin Krahl robin.krahl@ireas.org 2019-02-19T22:09:04Z urn:sha1:1e127de5173e3b8fb62efc79f97651ca22694441 The data sent with Set_Report requests contains a CRC which we so far ignored. This patch adds a Crc struct that uses the CRC peripheral to calculate the CRC for some data and uses it to validate the CRC of the received data.