nitrokey-sys-rs, branch next low-level Rust bindings for libnitrokey https://git.ireas.org/nitrokey-sys-rs/atom?h=next 2020-09-23T11:11:48Z Update contribution information in readme 2020-09-23T11:11:48Z Robin Krahl robin.krahl@ireas.org 2020-09-23T11:11:48Z urn:sha1:d1e170d76997e3cc5fae1e071bd4547b91164315 Add the Librem Key model to the unit tests 2020-09-23T11:04:11Z Robin Krahl robin.krahl@ireas.org 2020-09-23T11:04:11Z urn:sha1:8f037261c096cab27ad2d11c199217620625e09a Add verify-bindings make target 2020-09-23T11:03:44Z Robin Krahl robin.krahl@ireas.org 2020-09-23T10:52:46Z urn:sha1:6d5ca96e4f401b446b2e9490b6d24de5e639880c This patch adds the verify-bindings make target that re-generates the bindings using bindgen and verifies that they do not differ from the pre-generated bindings in the Git repository. Add feature to generate bindings during build 2020-09-22T17:09:40Z Robin Krahl robin.krahl@ireas.org 2020-09-22T17:09:40Z urn:sha1:c484777f3a7dde9e9fe8f47344fd8a6b30840b78 This patch adds the bindgen feature to the crate that allows users to re-generate the bindings, including layout tests, during the build instead of using the pre-generated bindings. Per default, this feature is disabled. Do not include layout tests in generated bindings 2020-09-22T16:26:53Z Robin Krahl robin.krahl@ireas.org 2020-09-22T16:26:53Z urn:sha1:4932d2376cc03c64eb82972824be673cdc2e0741 We are generating the Rust bindings in src/ffi.rs using bindgen once for all platforms on an amd64 machine. These bindings previously included layout tests. But these tests fail on some 32-bit architecture. See this discussion for more information: https://lists.sr.ht/~ireas/nitrokey-rs-dev/%3C20200919182408.GA1513%40ireas.org%3E With this patch, we remove the layout tests from the generated bindings. Instead, we will add the option to re-generate the bindings, including the layout tests, during the build in the next patch. Automatically refresh patches 2020-09-20T10:00:08Z Robin Krahl robin.krahl@ireas.org 2020-09-20T09:55:18Z urn:sha1:7944af959ca0b48f0e8ea5c506e801e07a6b8124 This patch adds the --refresh option to the quilt push invocation in the Makefile to automatically update the patches if the context changed. Update to libnitrokey v3.6 2020-09-20T09:59:36Z Robin Krahl robin.krahl@ireas.org 2020-09-19T21:05:35Z urn:sha1:56eb89dcf5f7d2c3b4ea92490a3b4df6f85713c0 This patch updates libnitrokey from version 3.5 to version 3.6, causing these changes: - New constants: - `NK_device_model_NK_LIBREM` (`NK_device_model` enum) - New structures: - `NK_config` - New functions: - `NK_device_serial_number_as_u32` - `NK_write_config_struct` - `NK_free_config` - `NK_read_config_struct` - `NK_free_password_safe_slot_status` - Deprecated functions: - `NK_set_unencrypted_read_only` - `NK_set_unencrypted_read_write` Implement Display for Version in build.rs 2020-09-20T09:50:37Z Robin Krahl robin.krahl@ireas.org 2020-09-19T21:15:33Z urn:sha1:655b823d13acbb71bb1496df29a9008e1b0ee9a2 Previously, we implemented the std::string::ToString trait for the Version enum in build.rs for converting the libnitrokey version number to a string. This patch replaces this implementation with an implementation of the std::fmt::Display trait, which automatically generates a ToString implementation and is more idiomatic. Derive Default for libnitrokey structs 2020-09-20T09:50:05Z Robin Krahl me@robin-krahl.de 2020-09-20T03:01:06Z urn:sha1:e9a06bb9a2802a5ae6011fcd96cf54e1cfc7d311 This patch adds the --with-derive-default option to the bindgen invocation so that it derives Default implementations for all libnitrokey structs. This allows us to simplify code in nitrokey-rs, for example the initialization of structs that are used in nitrokey-sys functions with output parameters. Re-generate bindings in src/ffi.rs 2020-09-20T09:46:45Z Robin Krahl me@robin-krahl.de 2020-09-20T02:46:26Z urn:sha1:483ec7256d6c4d01ba6c41513fdf8bbd7df6b4b3 Older versions of bindgen rendered C++ doc comments as Rust doc comments using the /// syntax. Newer versions use the doc attribute instead. This patch re-generates the src/ffi.rs file with bindgen 0.55.1 so that it uses the new format. This makes it easier to perform changes in the future.