From aac8f14edf4986c4881267a5b76a58d6800945bb Mon Sep 17 00:00:00 2001 From: Robin Krahl Date: Mon, 21 May 2018 23:17:46 +0000 Subject: Use drop() instead of disconnect() Previously, the user had to explicitly call diconnect() to terminate the connection to the Nitrokey. Now NK_logout() is called automatically once the device is out of scope as UnauthenticatedDevice implements Drop. AdminAuthenticatedDevice and UserAuthenticatedDevice do not have to implement Drop, as it will be called recursively. --- TODO.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'TODO.md') diff --git a/TODO.md b/TODO.md index b9efdbd..b2fa21e 100644 --- a/TODO.md +++ b/TODO.md @@ -36,10 +36,10 @@ - `NK_list_devices_by_cpuID` - `NK_connect_with_ID` - Fix timing issues with the `totp` and `totp_pin` test cases. -- Consider implementing `Drop` instead of the method `disconnect`. - Find an example for `set_time`, also adapt `get_totp_code`. - Improve log level documentation. - Clear passwords from memory. - Find a nicer syntax for the `write_config` test. - Fix segmentation faults when freeing string literals with old Nitrokey versions (fixed in libnitrokey commit 7a8550d). +- Prevent construction of internal types. -- cgit v1.2.1