diff options
| author | Robin Krahl <robin.krahl@ireas.org> | 2019-01-17 14:21:44 +0000 |
|---|---|---|
| committer | Robin Krahl <robin.krahl@ireas.org> | 2019-01-20 22:15:29 +0100 |
| commit | d87859975dc158919ecd5bf11a1111a2da5fcb30 (patch) | |
| tree | 27eb8ac46b130e08d917a7b91da8b48a14b644b6 /tests/pws.rs | |
| parent | 17f9c30a0ace070cba856e4e89fcccedcab5e8e6 (diff) | |
| download | nitrokey-rs-d87859975dc158919ecd5bf11a1111a2da5fcb30.tar.gz nitrokey-rs-d87859975dc158919ecd5bf11a1111a2da5fcb30.tar.bz2 | |
Check specific error codes in the tests
If possible, check specific error codes instead of `is_err()`. This
makes the code more readable and catches bugs resulting in the wrong
error code. Also, using the assert_*_err and assert_ok macros yields
error messages containing the expected and the actual value.
To be able to use these macros with the `get_password_safe` method, we
also have to implement `Debug` for `PasswordSafe` and `Device`.
Diffstat (limited to 'tests/pws.rs')
| -rw-r--r-- | tests/pws.rs | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/tests/pws.rs b/tests/pws.rs index b89d7f6..7a97983 100644 --- a/tests/pws.rs +++ b/tests/pws.rs @@ -39,11 +39,9 @@ where #[test_device] fn enable(device: DeviceWrapper) { - assert!(device - .get_password_safe(&(USER_PASSWORD.to_owned() + "123")) - .is_err()); + assert_cmd_err!(CommandError::WrongPassword, device.get_password_safe(&(USER_PASSWORD.to_owned() + "123"))); assert!(device.get_password_safe(USER_PASSWORD).is_ok()); - assert!(device.get_password_safe(ADMIN_PASSWORD).is_err()); + assert_cmd_err!(CommandError::WrongPassword, device.get_password_safe(ADMIN_PASSWORD)); assert!(device.get_password_safe(USER_PASSWORD).is_ok()); } |