diff options
| author | Robin Krahl <robin.krahl@ireas.org> | 2020-01-28 20:31:56 +0100 |
|---|---|---|
| committer | Robin Krahl <robin.krahl@ireas.org> | 2020-01-28 21:05:33 +0100 |
| commit | ebd754d88330478981f65e4724cc561ceff4f9e7 (patch) | |
| tree | ba291f2a4303850fdab7233d0e2e6b0a98760690 /TODO.md | |
| parent | 777cbd0fee8187325b0272d3264b535828d4b4ea (diff) | |
| download | nitrokey-rs-ebd754d88330478981f65e4724cc561ceff4f9e7.tar.gz nitrokey-rs-ebd754d88330478981f65e4724cc561ceff4f9e7.tar.bz2 | |
Regenerate temporary passwords with null bytes
Previously, we silently cut off temporary passwords that contained a
null byte. With the change to CString, we returned a LibraryError
instead. With this patch, we change to generate_password function to
continue generating passwords until we have a password without a null
byte.
The chance of generating a password with a null byte is ca. 10 % for our
temporary password with 25 characters. Therefore the chance of having
to re-generate the password multiple times is low enough that we don’t
bother with re-generating only the null bytes of the password for the
time being. This should be improved in the future.
Diffstat (limited to 'TODO.md')
| -rw-r--r-- | TODO.md | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -6,5 +6,7 @@ SPDX-License-Identifier: CC0-1.0 - Clear passwords from memory. - Lock password safe in `PasswordSafe::drop()` (see [nitrokey-storage-firmware issue 65][]). +- Consider only regenerating the null bytes instead of the complete password in + `util::generate_password`. [nitrokey-storage-firmware issue 65]: https://github.com/Nitrokey/nitrokey-storage-firmware/issues/65 |