diff options
author | Robin Krahl <robin.krahl@ireas.org> | 2020-01-11 20:05:39 +0100 |
---|---|---|
committer | Robin Krahl <robin.krahl@ireas.org> | 2020-01-11 20:25:56 +0100 |
commit | dbee55efa41496c8a683bfab96163facc93d6639 (patch) | |
tree | 93aa1d17acd18b6884b8421c593dab6e7cbf6011 /TODO.md | |
parent | 1532f92de1d63613602acb0b68486361571f3e50 (diff) | |
download | nitrokey-rs-dbee55efa41496c8a683bfab96163facc93d6639.tar.gz nitrokey-rs-dbee55efa41496c8a683bfab96163facc93d6639.tar.bz2 |
Add support for the GET_STATUS command
This patch adds support for the GET_STATUS command that returns the
status information common to all Nitrokey devices. It can be accessed
using the Device::get_status function and is stored in a Status struct.
Due to a bug in the Storage firmware [0], the GET_STATUS command returns
wrong firmware versions and serial numbers. Until this is fixed in
libnitrokey [1], we have to manually execute the GET_DEVICE_STATUS
command to fix these values for the Nitrokey Storage.
Also, this leads to a name clash with the existing Storage::get_status
function, which will be renamed in an upcoming patch.
[0] https://github.com/Nitrokey/nitrokey-storage-firmware/issues/96
[1] https://github.com/Nitrokey/libnitrokey/issues/166
Diffstat (limited to 'TODO.md')
-rw-r--r-- | TODO.md | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -7,13 +7,12 @@ SPDX-License-Identifier: CC0-1.0 - `NK_fill_SD_card_with_random_data` - `NK_get_SD_usage_data` - `NK_get_progress_bar_value` - - `NK_get_status` -- waiting for [libnitrokey issue 166][] - Clear passwords from memory. - Lock password safe in `PasswordSafe::drop()` (see [nitrokey-storage-firmware issue 65][]). - Disable creation of multiple password safes at the same time. - Check timing in Storage tests. - Consider restructuring `device::StorageStatus`. +- Consider renaming `Storage::get_status` (cf. `Device::get_status`). -[libnitrokey issue 166]: https://github.com/Nitrokey/libnitrokey/issues/166 [nitrokey-storage-firmware issue 65]: https://github.com/Nitrokey/nitrokey-storage-firmware/issues/65 |