diff options
author | Robin Krahl <robin.krahl@ireas.org> | 2020-01-26 14:26:01 +0100 |
---|---|---|
committer | Robin Krahl <robin.krahl@ireas.org> | 2020-01-28 12:02:28 +0100 |
commit | 24eebcdaaa32d55bf49d069d8320be5dbd6fdab9 (patch) | |
tree | 075ae58eec1fbec7e16a14723f932aad08a7db49 /CHANGELOG.md | |
parent | da8727996efacec4280696caefee3feecea4eae7 (diff) | |
download | nitrokey-rs-24eebcdaaa32d55bf49d069d8320be5dbd6fdab9.tar.gz nitrokey-rs-24eebcdaaa32d55bf49d069d8320be5dbd6fdab9.tar.bz2 |
Always store serial numbers as integers
This patch consistently uses u32 integers to store and return the serial
number of a Nitrokey device. This makes it easier to convert and
compare the serial number, as it is a unique representation and as
formatting an integer cannot fail. For more details, see this RFC:
https://lists.sr.ht/~ireas/nitrokey-rs-dev/%3C20200126074816.GA1314%40ireas.org%3E
Diffstat (limited to 'CHANGELOG.md')
-rw-r--r-- | CHANGELOG.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index da9b2f3..4c0f6b4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,11 @@ SPDX-License-Identifier: CC0-1.0 # Unreleased - Add `String` value to the `Error::UnexpectedError` variant. +- Always store serial numbers as integers: + - Change the return type of `Device::get_serial_number` from `Result<String, + _>` to `Result<u32, _>`. + - Change the type of the field `DeviceInfo.serial_number` from + `Option<String>` to `Option<u32>`. # v0.5.1 (2020-01-15) - Fix serial number formatting for Nitrokey Pro devices with firmware 0.8 or |