nitrokey-rs/src, branch v0.5.2

Regenerate temporary passwords with null bytes

2020-01-28T20:05:33Z

Previously, we silently cut off temporary passwords that contained a null byte. With the change to CString, we returned a LibraryError instead. With this patch, we change to generate_password function to continue generating passwords until we have a password without a null byte. The chance of generating a password with a null byte is ca. 10 % for our temporary password with 25 characters. Therefore the chance of having to re-generate the password multiple times is low enough that we don’t bother with re-generating only the null bytes of the password for the time being. This should be improved in the future.

Remove AuthenticatedDevice::temp_password_ptr

2020-01-28T20:05:13Z

We introduced the AuthenticatedDevice::temp_password_ptr function to reduce the number of casts needed in our code base. Since we switched from Vec to CString, we no longer have to cast the return value of as_ptr. Therefore we can remove the temp_password_ptr function to reduce code complexity.

Use CString to store temporary passwords

2020-01-28T20:05:03Z

This patch changes the generate_password function and the User and Admin structs to use a CString instead of a Vec when storing temporary passwords. This makes sure that the strings that are passed to the C API are properly null-terminated.

Fix serial number for older Nitrokey Pro in list_devices

2020-01-15T12:19:13Z

Previously, we assumed that the serial number returned by hidapi contains the Nitrokey serial number as the least significant bytes. As disussed here [0], this is not true for Nitrokey Pro devices with firmware version 0.8 or older: They write the serial number to the most significant bytes instead. This patch update the get_hidapi_serial_number function so that list_devices now returns the correctly formatted and truncated serial number for all Nitrokey Pro devices. It also makes sure that the serial number is lowercase to be consistent with libnitrokey’s formatting.

Document background operations

2020-01-14T15:54:00Z

This patch adds a new section about background operations to the crate documentation.

Add the fill_sd_card function to Storage

2020-01-14T15:53:52Z

This patch adds support for libnitrokey’s NK_fill_SD_card_with_random_data function. It is executed by the fill_sd_card function of the Storage struct. We also add a new test case that is set to ignore because it takes between 30 and 60 minutes to run.

Add the get_operation_status function to the Storage struct

2020-01-14T15:53:45Z

This patch adds support for the NK_get_progress_bar_value function: It adds the OperationStatus enum that stores the return value of this command and adds the get_operation_status function to the Storage struct that executes the command.

Derive Clone, Copy, Debug, PartialEq for Status

2020-01-14T15:53:35Z

Somehow I forgot to derive the common traits for the new Status struct. This patch adds the missing derive attribute for Clone, Copy, Debug and PartialEq.

Add the get_sd_card_usage function to the Storage struct

2020-01-14T11:06:23Z

This patch adds support for the NK_get_SD_usage_data function. It returns a range of the SD card that has not been accessed during this power cycle.

Rename Status::get_status to get_storage_status

2020-01-11T19:26:40Z

In the last patch, we added the get_status function to the Device trait. This patch renames the Storage::get_status function to get_storage_status to resolve the name clash – though allowed by the compiler, it is rather confusing for the end user.