Rust interface to libnitrokey https://git.ireas.org/nitrokey-rs/atom?h=v0.4.0-alpha.3 2019-07-09T10:47:26Z 2019-07-09T10:47:26Z Robin Krahl robin.krahl@ireas.org 2019-07-09T10:44:45Z urn:sha1:5e8f0fbaf6df0cb919e4b02401cc21d5280bf09c The take and take_blocking functions return a PoisonError if the cache is poisoned, i. e. if a thread panicked while holding the manager. This is a sensible default behaviour, but for example during testing, one might want to ignore the poisoned cache. This patch adds the force_take function that unwraps the PoisonError and returns the cached Manager even if the cache was poisoned. 2019-07-09T10:23:14Z Robin Krahl robin.krahl@ireas.org 2019-07-09T10:22:08Z urn:sha1:88b32f5c2187e59fece93cd245aeadb4e5f9e04a During the connection manager refactoring, we temporarily used deprecated methods. This is no longer the case, so we can remove the allow(deprecated) attribute. 2019-07-09T08:44:08Z Robin Krahl robin.krahl@ireas.org 2019-01-27T19:52:53Z urn:sha1:62e8ee8f5d02511d6eb5dc179b087b04e88c1b94 This patch updates the documentation to reflect the latest changes to connection handling. It also updates the doc tests to prefer the new methods over the old ones. 2019-07-09T08:27:55Z Robin Krahl robin.krahl@ireas.org 2019-07-09T08:09:02Z urn:sha1:12fa62483cf45d868099d5d4020333af492eebde To enable applications like nitrokey-test to go back to a manager instance from a Device instance, we add the into_manager function to the Device trait. To do that, we have to keep track of the Manager’s lifetime by adding a lifetime to Device (and then to some other traits that use Device). 2019-07-08T21:40:17Z Robin Krahl robin.krahl@ireas.org 2019-01-27T18:42:14Z urn:sha1:fe2f39826ade5a156945dabb8c8ab725378a15c1 In the last patches, we ensured that devices can only be obtained using the Manager struct. But we did not ensure that there is only one device at a time. This patch adds a mutable reference to the Manager instance to the Device implementations. The borrow checker makes sure that there is only one mutable reference at a time. In this patch, we have to remove the old connect, Pro::connect and Storage::connect functions as they do no longer compile. (They discard the MutexGuard which invalidates the reference to the Manager.) Therefore the tests do no longer compile. 2019-07-08T21:33:13Z Robin Krahl robin.krahl@ireas.org 2019-01-27T18:21:08Z urn:sha1:379bc798477a1de7ffda923c5d10ca63aebae25f As part of the connection refactoring, this patch moves the connect methods of the Pro and Storage structs into the Manager struct. To maintain compatibility with nitrokey-test, the old methods are not removed but marked as deprecated. 2019-07-08T21:31:40Z Robin Krahl robin.krahl@ireas.org 2019-01-27T18:07:59Z urn:sha1:bd7c7a5fdf0ae66a1ff2f00beb5ed4c2e6994ca1 As part of the connection refactoring, this patch moves the connect_model function to the Manager struct. As the connect_model function is not used by nitrokey-test, it is removed. 2019-07-08T21:27:11Z Robin Krahl robin.krahl@ireas.org 2019-01-27T17:44:59Z urn:sha1:54d23475aa3b712a539bad129fe37223173268f2 As part of the connection refactoring, we replace the connect function with the Manager::connect method. To maintain compatibility with nitrokey-test, the connect function is not removed but marked as deprecated. 2019-07-08T21:27:11Z Robin Krahl robin.krahl@ireas.org 2019-01-27T15:43:32Z urn:sha1:588066f415e956fdcd2c6f6216c52b25911a3b1d As part of the connection refactoring, we introduce the Manager struct that deals with connection management. To make sure there can be only once instance of the manager, we add a global static Mutex that holds the single Manager instance. We use the struct to ensure that the user can only connect to one device at a time. This also changes the Error::PoisonError variant to store the sync::PoisonError. This allows the user to call into_inner on the PoisonError to retrieve the MutexGuard and to ignore the error (for example useful during testing). 2019-07-08T21:27:03Z Robin Krahl robin.krahl@ireas.org 2019-01-27T15:04:19Z urn:sha1:a52676d9577f587e0f4d8e47ddc71ba34f0b31ca This patch prepares the refactoring of the connection methods by introducing the Error variants ConcurrentAccessError and PoisonError. ConcurrentAccessError indicates that the user tried to connect to obtain a token that is currently locked, and PoisonError indicates that a lock has been poisoned, i. e. a thread panicked while accessing using a token.