nitrokey-rs/src, branch v0.4.0-alpha.0

Use if instead of match for boolean expression

2019-01-27T14:04:24Z

Replace or with or_else in get_cstring

2019-01-27T13:42:12Z

To avoid unnecessary function calls, we replace the or with an or_else in get_cstring.

Remove the static lifetime modifier from constants

2019-01-27T13:38:16Z

The DEFAULT_{ADMIN,USER}_PIN constants implicitly have static lifetime. Therefore we can remove the static lifetime modifiers.

Rename Error::Unknown to Error::UnknownError

2019-01-27T13:38:07Z

For consistency with the other Error variants, we rename Unknown to UnknownError.

Remove the Result typedef

2019-01-27T13:31:36Z

Many of our functions do not return a Result<_, Error>, but for example a Result<_, (Device, Error)>. We only use the typedef in one function, but it makes the other functions more complicated as we have to use result::Result (if crate::Result is imported). Therefore, this patch removes the typedef. Applications or libraries can still redefine it if they want to.

Remove rand_core::Error from public API

2019-01-25T18:49:35Z

rand_core does not have a stable release yet, and it is unlikely that there will be one soon. To be able to stabilize nitrokey without waiting for a stable rand_core version, we remove the rand_core::Error type from the public API and replace it with a Box.

Add license and copyright information

2019-01-23T15:33:26Z

This patch adds license and copyright information to all files to make nitrokey-rs compliant with the REUSE practices [0]. [0] https://reuse.software/practices/2.0/

Implement From<(T: Device, Error)> for Error

2019-01-23T04:38:30Z

Not all users of the authenticate methods want to use the device after an error, so implementing From<(T: Device, Error)> for Error makes it easier for them to discard the device.

Return UTF-8 error if libnitrokey returns an invalid string

2019-01-23T04:30:23Z

Previously, we used lossy UTF-8 conversion. Yet the user should be notified if we have a problem instead of silently changing the data. Therefore, we now return an error if we enocunter an invalid UTF-8 string. This leads to a change in `get_library_version`’s signature.

Add Error::Utf8Error variant

2019-01-23T04:26:15Z

Previously, we just ignored UTF-8 errors. This patch prepares the Utf8Error variant so that we are able to return UTF-8 errors.