nitrokey-rs/src, branch v0.3.4

Pass temporary password as *const c_char

2019-01-20T13:58:11Z

The random number generator used for the temporary password produces a Vec. The libnitrokey functions using the temporary password require a pointer to a c_char. Previously, we cast the u8 pointer to the Vec to a i8 pointer (unsigned to signed). This leads to a type mismatch if the char type is not signed. Therefore we now cast to c_char instead of i8.

Document and test empty Git versions

2019-01-16T20:29:38Z

If libnitrokey has not been built from a clone of the Git repository, the Git version string may be empty.

pws: Interpret empty strings as unprogrammed slots

2019-01-16T19:17:16Z

Until the last commit, all empty strings returned by the library were interepreted as errors. As the PWS functions return empty strings for unprogrammed slots, the methods to access the PWS data returned an error when querying a slot that is not programmed. Since the last commit, they return an empty string instead. This patch restores the old behavior by returning an error instead of an empty string. Yet we change the error variant: SlotNotProgrammed instead of Undefined.

Fix result_from_string for empty return values

2019-01-16T19:17:07Z

An empty string returned from a libnitrokey function can either indicate an error or be a valid return value. Previously, we assumed that it indicates an error. But instead, we should check the last command status and use it to decide whether to return the empty string or an error code. This breaks the unit tests that assume that empty strings cause errors. These will be fixed in the next patches.

Fix typo: destory -> destroy

2019-01-16T01:45:25Z

Use rand_os for random data generation

2019-01-14T19:30:59Z

The rand crate comes with a slew of dependencies to cover all sort of randomness related tasks in various scenarios. However, this crate really only requires a tiny subset of this functionality. As it turns out, this core functionality is provided by the rand_os crate. This change drops the dependency to rand in favor of rand_os. In order to accomplish that, it brings back the RngError variant for the CommandError enum to capture the possibility of the creation of the random number generator failing.

Add the clear_new_sd_card_warning method to Storage

2019-01-14T17:37:07Z

The clear_new_sd_card_warning method calls the libnitrokey NK_clear_new_sd_card_warning function to reset the corresponding flag in the Storage status.

Add the get_production_info method to the Storage struct

2019-01-14T15:28:58Z

The get_production_info method maps to the NK_get_production_info function of libnitrokey. The Storage firmware supports two query modes: with or without a write test. libnitrokey only performs the query without write test, so the fields that are only set for the write test are ignored in our implementation. This affects: - user and admin retry counts - smart card ID - SD card size

Add export_firmware method to Storage

2019-01-12T17:39:10Z

The export_firmware method writes the firmware of the Nitrokey Storage to the unencrypted storage. We only test that the command succeeds as mounting the unencrypted storage and accessing the file is out of scope for the tests.

Add set_unencrypted_volume_mode to Storage

2019-01-12T17:16:39Z

The new set_unencrypted_volume_mode method sets the access mode of the unencrypted volume on the Nitrokey Storage. Depending on the requested access mode, it calls either NK_set_unencrypted_read_only_admin or NK_set_unencrypted_read_write_admin. Note that this function requires firmware version 0.51 or later. (Earlier firmware versions used the user PIN.)