nitrokey-rs, branch v0.7.1

Release v0.7.1

2020-08-30T17:02:36Z

This patch release contains a minor change to the Error enum so that error handling frameworks like anyhow don’t produce redundant error messages.

Use map_err(|_| x) instead of or_else(|_| Err(x))

2020-08-30T16:52:15Z

Remove custom source implementation for Error

2020-08-30T16:43:31Z

This patch removes the custom implementation of the source method of the std::error::Error trait for the error::Error type. This means that the default implementation is used that always returns None. The reason for this change is that we already print the error message of the source error in the Display implementation. This leads to a duplicated error message if both Display and source are checked, for example with anyhow’s error formatting. See this thread for more information: https://lists.sr.ht/~ireas/nitrokey-rs-dev/%3C6e0b4dc8-9059-a113-e98e-b49e52818c75%40posteo.net%3E

Merge branch 'release-0.7.0' into next

2020-07-14T20:00:26Z

Release v0.7.0

2020-07-14T19:53:02Z

This release changes the Error enum to implement Send, Sync and 'static for compatibility with error handling crates like anyhow.

Merge branch 'poison-error' into next

2020-07-14T19:43:37Z

This patch series refactors the Error enum and ensures that it is Send, Sync and 'static. This makes sure that it is compatible with the anyhow crate. To achieve this, we drop the RandError variant and remove the sync::PoisonError value from the PoisonError variant.

Ensure Error trait implementations

2020-07-08T21:03:02Z

The anyhow crate requires that error types are error::Error, Send, Sync and 'static. This patch implements a simple static assertion that our Error type implements these traits.

Remove Error::RandError variant

2020-07-08T21:02:56Z

Since we update rand_os to version 0.2 in commit 6c138eaa850c745b97b7e48a201db0cbaad8e1e0, the random number generation can no longer fail. Therefore the Error::RandError variant is no longer needed. As we did not want to break the public API, we still kept the RandError variant. This patch removes the RandError variant for good.

Remove sync::PoisonError from Error::PoisonError

2020-07-08T21:02:49Z

Previously, the Error::PoisonError contained the sync::PoisonError that caused the error. This is problematic as sync::PoisonError does not implement Send, making it impossible to use the Error enum with the anyhow crate. At the same time, storing the sync::PoisonError is not very useful. If a user wants to access the poisoned lock, they can call the force_take function. Therefore we remove the sync::PoisonError value from the Error:: PoisonError variant. This also allows us to simplify the From> and From> implementations as we no longer need to know the type of the mutex that caused the error. For more information, see this thread: https://lists.sr.ht/~ireas/nitrokey-rs-dev/%3C68ed0f3f-d98f-63bc-04d2-81b6d6cde560%40posteo.net%3E

Use find(…) instead of skip_while(…).next()

2020-07-08T21:02:43Z

This patch replaces calls to skip_while(…).next() for an iter::Iterator with a call to find(…), as suggested by clippy.