Rust interface to libnitrokey https://git.ireas.org/nitrokey-rs/atom?h=v0.4.0-alpha.2 2019-07-15T06:18:51Z 2019-07-15T06:18:51Z Robin Krahl robin.krahl@ireas.org 2019-07-15T06:18:05Z urn:sha1:34efcfadf1436102e42144f710edabaa2c4b55cd 2019-07-05T22:46:14Z Robin Krahl robin.krahl@ireas.org 2019-07-05T22:42:56Z urn:sha1:381666ed17e0d85293f52493f852480bee70783b Firstly, the libnitrokey API contains breaking changes between minor versions. Therefore we have to fix the nitrokey-sys version using a tilde requirement ("~3.4" means ">= 3.4.0, < 3.5.0"). Secondly, nitrokey-test’s 0.2.1 release requires some changes that are not yet implemented in this crate, so we have to pin its version to 0.2.0. 2019-07-05T22:30:38Z Robin Krahl robin.krahl@ireas.org 2019-07-05T22:30:38Z urn:sha1:d426f1a56fedbb8b9fdc6c797f837a770e923029 The tests with the 0.4.0-alpha.1 version showed that the approach using mutable references to the Device in User, Admin and PasswordSafe causes problems in nitrocli, see [0]. Therefore, these changes are reverted. [0] https://lists.sr.ht/~ireas/nitrokey-rs-dev/%3C43cc304d-23e8-7f95-2167-ce3f0530b81e%40posteo.net%3E * revert: Revert "Store mutable reference to Device in PasswordSafe" Revert "Refactor User and Admin to use a mutable reference" 2019-02-05T14:52:54Z Robin Krahl robin.krahl@ireas.org 2019-02-05T12:48:01Z urn:sha1:d95355e3d76c0c0022629e635f36a2dc325c0af2 This reverts commit 13006c00dcbd570cf8347d89557834e320427377. 2019-02-05T14:48:24Z Robin Krahl robin.krahl@ireas.org 2019-02-05T12:47:24Z urn:sha1:83641ca0518e4c766c63e40d0787e4f0b436652a This reverts commit 0972bbe82623c3d9649b6023d8f50d304aa0cde6. 2019-02-04T00:30:25Z Robin Krahl robin.krahl@ireas.org 2019-02-04T00:29:11Z urn:sha1:606177a61de39ba5e96390d63cff536f895d8c39 In a previous commit, we introduced the DEFAULT_{ADMIN,USER}_PIN constants. Therefore we no longer need in the {ADMIN,USER}_PASSWORD constants in the util module for the tests. 2019-02-02T10:36:37Z Robin Krahl robin.krahl@ireas.org 2019-02-02T10:36:37Z urn:sha1:2fe3d9ee071647b6cb48cc6186235144a9575bed 2019-02-02T10:27:52Z Robin Krahl robin.krahl@ireas.org 2019-02-02T10:27:52Z urn:sha1:a31f73db289b00f81c5f70e60807ef7348f1a499 RFC: https://lists.sr.ht/~ireas/nitrokey-rs-dev/%3C20190126174327.tbuyk2s535kfiqm4%40localhost%3E https://lists.sr.ht/~ireas/nitrokey-rs-dev/%3C43cc304d-23e8-7f95-2167-ce3f0530b81e%40posteo.net%3E * mutable-references: Store mutable reference to Device in PasswordSafe Refactor User and Admin to use a mutable reference Require mutable reference if method changes device state Add device_mut method to DeviceWrapper Implement DerefMut for User and Admin 2019-02-02T10:25:37Z Robin Krahl robin.krahl@ireas.org 2019-01-30T18:40:11Z urn:sha1:13006c00dcbd570cf8347d89557834e320427377 The current implementation of PasswordSafe stored a normal reference to the Device. This patch changes the PasswordSafe struct to use a mutable reference instead. This allows the borrow checker to make sure that there is only one PasswordSafe instance at a time. While this is currently not needed, it will become important once we can lock the PWS on the Nitrokey when dropping the PasswordSafe instance. 2019-02-02T10:25:02Z Robin Krahl robin.krahl@ireas.org 2019-01-28T14:24:12Z urn:sha1:0972bbe82623c3d9649b6023d8f50d304aa0cde6 In the initial nitrokey-rs implementation, the Admin and the User struct take the Device by value to make sure that the user cannot initiate a second authentication while this first is still active (which would invalidate the temporary password). Now we realized that this is not necessary – taking a mutable reference has the same effect, but leads to a much cleaner API. This patch refactors the Admin and User structs – and all dependent code – to use a mutable reference instead of a Device value.