Rust interface to libnitrokey https://git.ireas.org/nitrokey-rs/atom?h=v0.3.3 2019-01-16T20:36:49Z 2019-01-16T20:36:49Z Robin Krahl robin.krahl@ireas.org 2019-01-16T20:36:49Z urn:sha1:7cf747d56ddc0b7eeedc3caf36dcc909907a171c 2019-01-16T20:32:11Z Robin Krahl robin.krahl@ireas.org 2019-01-16T20:32:11Z urn:sha1:ea84e4609421ee5ce3bebbb9f52ef302fe2fba56 The archlinux build compiles libnitrokey from source. Now we also verify that we can use the system libnitrokey version. 2019-01-16T20:29:38Z Robin Krahl robin.krahl@ireas.org 2019-01-16T20:28:31Z urn:sha1:679791064169a37ad9d88b910b7553ebf7133c07 If libnitrokey has not been built from a clone of the Git repository, the Git version string may be empty. 2019-01-16T20:22:48Z Robin Krahl robin.krahl@ireas.org 2019-01-16T20:20:31Z urn:sha1:d72641832a6c8622cf6468987b5b0aa5bd4c1c39 There seems to be a bug in libnitrokey or the Nitrokey Storage firmware that causes problems when chaining factory reset and build_AES_keys without delay (upstream issue [0]). [0] https://github.com/Nitrokey/nitrokey-storage-firmware/issues/80 2019-01-16T20:22:41Z Robin Krahl robin.krahl@ireas.org 2019-01-16T19:43:04Z urn:sha1:3a8669cea4aa4b32fee3336cb9be4ec66d3dc2c2 The device::clear_new_sd_card_warning used to perform a factory reset without building an AES key. This led to errors in tests that assume that an AES key is present. 2019-01-16T20:22:31Z Robin Krahl robin.krahl@ireas.org 2019-01-16T19:35:50Z urn:sha1:d3a103bc25e5f37a42a19515ad25e5a8e5995b36 The device::factory_reset test used to first change the PINs and then access the PWS and the OTP data. If for example the PWS access failed due to an problem with the AES key, the PINs were not reset. Now we perform the PWS and OTP access with the old PINs – which is okay as we do not want to test the PIN change but the factory reset. If these preparations fail, the tests is cancelled before the PINs are changed. 2019-01-16T19:17:16Z Robin Krahl robin.krahl@ireas.org 2019-01-16T03:16:01Z urn:sha1:79a3298ab5973a47cb68ef48e554ec88fb7e99a6 Until the last commit, all empty strings returned by the library were interepreted as errors. As the PWS functions return empty strings for unprogrammed slots, the methods to access the PWS data returned an error when querying a slot that is not programmed. Since the last commit, they return an empty string instead. This patch restores the old behavior by returning an error instead of an empty string. Yet we change the error variant: SlotNotProgrammed instead of Undefined. 2019-01-16T19:17:07Z Robin Krahl robin.krahl@ireas.org 2019-01-16T02:52:58Z urn:sha1:3c8092cd937d6f449b1959eab9e7e15549970d85 An empty string returned from a libnitrokey function can either indicate an error or be a valid return value. Previously, we assumed that it indicates an error. But instead, we should check the last command status and use it to decide whether to return the empty string or an error code. This breaks the unit tests that assume that empty strings cause errors. These will be fixed in the next patches. 2019-01-16T01:45:25Z Daniel Mueller deso@posteo.net 2019-01-16T01:15:34Z urn:sha1:7c2bb330b125cde7ceb55616b3d8c50a98840c58 2019-01-15T17:03:19Z Robin Krahl robin.krahl@ireas.org 2019-01-15T15:17:48Z urn:sha1:52501733d4f678b4012e514261cbecfc2a12a229