Rust interface to libnitrokey https://git.ireas.org/nitrokey-rs/atom?h=master 2020-08-30T17:09:17Z 2020-08-30T17:09:17Z Robin Krahl robin.krahl@ireas.org 2020-08-30T17:09:17Z urn:sha1:21de2b96335b3cfcaea9b96592fe5eef34f81126 2020-08-30T17:02:36Z Robin Krahl robin.krahl@ireas.org 2020-08-30T17:02:36Z urn:sha1:1d36e2e1195fc9046e36f38dfe943198027e84ca This patch release contains a minor change to the Error enum so that error handling frameworks like anyhow don’t produce redundant error messages. 2020-08-30T16:52:15Z Robin Krahl robin.krahl@ireas.org 2020-08-30T16:52:15Z urn:sha1:b2607cbd3f239be9d09204921db278424cc7a6be 2020-08-30T16:43:31Z Robin Krahl robin.krahl@ireas.org 2020-08-30T16:43:31Z urn:sha1:e9a89be939acf22cf17e3d6bc505a968a98d3dee This patch removes the custom implementation of the source method of the std::error::Error trait for the error::Error type. This means that the default implementation is used that always returns None. The reason for this change is that we already print the error message of the source error in the Display implementation. This leads to a duplicated error message if both Display and source are checked, for example with anyhow’s error formatting. See this thread for more information: https://lists.sr.ht/~ireas/nitrokey-rs-dev/%3C6e0b4dc8-9059-a113-e98e-b49e52818c75%40posteo.net%3E 2020-07-14T20:00:26Z Robin Krahl robin.krahl@ireas.org 2020-07-14T20:00:26Z urn:sha1:4e36005680285a20ec50580f79ece8ec47f648e3 2020-07-14T20:00:13Z Robin Krahl robin.krahl@ireas.org 2020-07-14T20:00:13Z urn:sha1:3810761847717676d91900c422d9c8b634f56d77 2020-07-14T19:53:02Z Robin Krahl robin.krahl@ireas.org 2020-07-14T19:52:06Z urn:sha1:8f72f038cab8e61fb162c12c4bd4cbaa243faa2d This release changes the Error enum to implement Send, Sync and 'static for compatibility with error handling crates like anyhow. 2020-07-14T19:43:37Z Robin Krahl robin.krahl@ireas.org 2020-07-14T19:43:37Z urn:sha1:d0f517eec5fbeb402a42eb2b23ca13fc85f1bc98 This patch series refactors the Error enum and ensures that it is Send, Sync and 'static. This makes sure that it is compatible with the anyhow crate. To achieve this, we drop the RandError variant and remove the sync::PoisonError value from the PoisonError variant. 2020-07-08T21:03:02Z Robin Krahl robin.krahl@ireas.org 2020-07-08T20:58:41Z urn:sha1:f1e83eb81879412e1de9898238ba58289bb6cb24 The anyhow crate requires that error types are error::Error, Send, Sync and 'static. This patch implements a simple static assertion that our Error type implements these traits. 2020-07-08T21:02:56Z Robin Krahl robin.krahl@ireas.org 2020-07-08T20:22:10Z urn:sha1:3f402dc13530ce4de167bae843200cfbd72ed69b Since we update rand_os to version 0.2 in commit 6c138eaa850c745b97b7e48a201db0cbaad8e1e0, the random number generation can no longer fail. Therefore the Error::RandError variant is no longer needed. As we did not want to break the public API, we still kept the RandError variant. This patch removes the RandError variant for good.