From 1d62e9151369ab50d98d638e80753630c0c3cbbf Mon Sep 17 00:00:00 2001 From: Daniel Mueller Date: Sat, 13 Jul 2019 22:36:53 -0700 Subject: Downgrade crate-level lints to 'warn' We recently fixed a compilation failure in some test code caused by a use declaration that was ultimately unused. To this point we were under the impression that there was a set of lints that were known to be potentially changing in backwards incompatible ways while others would not. Discovery of unused use declarations or symbols was always assumed to fall into the latter category. Because such a build breakage due to semantic change in what a lint can detect by now is a repeated pattern (with dire consequences), this change downgrades all 'deny'-style lints to warnings in order to prevent similar problems in the future. --- nitrocli/src/main.rs | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/nitrocli/src/main.rs b/nitrocli/src/main.rs index ffc2744..57fbceb 100644 --- a/nitrocli/src/main.rs +++ b/nitrocli/src/main.rs @@ -17,8 +17,10 @@ // * along with this program. If not, see . * // ************************************************************************* -#![deny( +#![warn( + bad_style, dead_code, + future_incompatible, illegal_floating_point_literal_pattern, improper_ctypes, intra_doc_link_resolution_failure, @@ -28,12 +30,16 @@ missing_docs, no_mangle_generic_items, non_shorthand_field_patterns, + nonstandard_style, overflowing_literals, path_statements, patterns_in_fns_without_body, plugin_as_library, private_in_public, proc_macro_derive_resolution_fallback, + renamed_and_removed_lints, + rust_2018_compatibility, + rust_2018_idioms, safe_packed_borrows, stable_features, trivial_bounds, @@ -55,14 +61,6 @@ where_clauses_object_safety, while_true )] -#![warn( - bad_style, - future_incompatible, - nonstandard_style, - renamed_and_removed_lints, - rust_2018_compatibility, - rust_2018_idioms -)] //! Nitrocli is a program providing a command line interface to certain //! commands of Nitrokey Pro and Storage devices. -- cgit v1.2.3