Robin Krahl's fork of nitrocli https://git.ireas.org/nitrocli/atom?h=otp-cache 2020-08-26T02:04:50Z 2020-08-26T02:04:50Z Daniel Mueller deso@posteo.net 2020-08-26T02:04:50Z urn:sha1:223c8484f727451d15ad23ffb0133a1858b56b5c This change introduces support for discovering and executing user-provided extensions to the program. Extensions are useful for allowing users to provide additional functionality on top of the nitrocli proper. Implementation wise we stick to an approach similar to git or cargo subcommands in nature: we search the directories listed in the PATH environment variable for a file that starts with "nitrocli-", followed by the extension name. This file is then executed. It is assumed that the extension recognizes (or at least not prohibits) the following arguments: --nitrocli (providing the path to the nitrocli binary), --model (with the model passed to the main program), and --verbosity (the verbosity level). 2020-08-25T01:04:20Z Daniel Mueller deso@posteo.net 2020-08-25T01:04:20Z urn:sha1:b114125dfbb4c97580ae076c07c6816ccdca51b8 In the future we would like to provide more ways for tests to create a Nitrocli instance. In order to prevent explosion of with_XXX methods for each possible combination of arguments, this change introduces a Builder struct that can be used to create such an instance in an idiomatic way. 2020-07-08T00:35:50Z Daniel Mueller deso@posteo.net 2020-07-08T00:35:50Z urn:sha1:147d01663f9b95c6819d3c6afe8694cd291dbc3d An arguably unrepresentative survey of services (GitHub, Google Authenticator, and Bitbucket) seems to suggests that the base32 format is the de-facto standard format for OTP secrets. Given that it's not necessarily obvious what format a secret is in and that most services refrain from mentioning it explicitly, having the correct default format is fairly important. With this change we switch the default format from hexadecimal to base32 to accommodate for this finding. 2020-07-03T15:30:57Z Daniel Mueller deso@posteo.net 2020-07-03T15:30:57Z urn:sha1:6dd0dafdd53b990cfba79529a36352e11fe0385e Our custom macros for conveniently creating types with additional meta information for working with structopt do not actually use the doc comments we have in place -- these comments are solely for in-source documentation. We are an application and as such crates.io will not automatically generate documentation. All of that does not deter rustc from complaining that doc comments are unused. In the past we tried to fudge that by adding a special allowance, #[allow(unused_doc_comments)], but that seems to have seized to work. With this change we finally give in and move the doc comment into the macro itself, where it will be used to annotate the generated type. This step should hopefully silence rustc once and for all -- at the expense of a slight decrease in readability. 2020-04-11T22:00:06Z Daniel Mueller deso@posteo.net 2020-04-11T22:00:06Z urn:sha1:f2ace56200f0229a4dcbd1767f48a39e1daa343d We have never been fully satisfied with the name arg_defs. Now that we have gotten rid of the formerly used args module, this change renames arg_defs to args. 2020-04-11T20:23:52Z Daniel Mueller deso@posteo.net 2020-04-11T20:23:52Z urn:sha1:fafbf4a1bf635d5eea049cf561fbf8aa293c8e2b This change removes the args module by moving all remaining functionality in it into main.rs. The result is arguably a nice consolidation of all context related definitions in a single module. 2020-04-11T19:29:22Z Daniel Mueller deso@posteo.net 2020-04-11T19:29:22Z urn:sha1:93c605418568bf71bcc3be6956f07f9650b45fea As a next step moving us closer towards removing the args module, this change merges the config_set function into the existing function of the same name in the commands module. 2020-04-10T19:20:18Z Daniel Mueller deso@posteo.net 2020-04-10T19:20:18Z urn:sha1:eae8b2a1f0d1faf70776fccc12c93267a2143021 Now that we have isolated and separated out structopt specific definitions into a new module, arg_defs, args.rs is actually so small that we do not want to keep it around any longer. This change marks a first step moving us closer towards removing it. Specifically, it merges the otp_set function from args.rs into the function of the same name in commands.rs. 2020-04-04T17:44:29Z Daniel Mueller deso@posteo.net 2020-04-04T17:44:29Z urn:sha1:c0ae9e64695b44d372657e1a6521145bde5498d3 We are aiming to rid the arg_defs module of dependencies to the rest of the crate in an attempt to make the file fully free standing. The last remaining references into the crate are used to hook up the functionality backing the respective commands. Luckily for us, this "gluing" of functionality to types is really only required in the macro-generated code (which we do not care about as part of this exercise) and so with this change we remove the use declarations from the top of the file and reference the respective functionality in an absolute manner instead. 2020-04-04T17:38:24Z Daniel Mueller deso@posteo.net 2020-04-04T17:38:24Z urn:sha1:83d3e90248e9995e6c37c314b10597bccd394341 This change removes the need to import crate::Error from the arg_defs module. By dropping this dependency we make the file more independent of the rest of the crate, which subsequently will allow us to merely include! it in another file in order to get the argument related type definitions without compilation errors due to missing symbols from the rest of the crate.