From f01d63d978505badf3400df54b592e51dc0f7654 Mon Sep 17 00:00:00 2001 From: Daniel Mueller Date: Tue, 8 Jan 2019 20:46:27 -0800 Subject: Show fmt::Display formatted errors instead of fmt::Debug ones At some point in the past nitrokey::CommandError was lacking an implementation of the fmt::Display trait. Hence, we fell back to printing these errors in debug format. Since version 0.2.0 of the crate fmt::Display is implemented for these errors. With this change we use it to report more user-friendly error messages. --- nitrocli/CHANGELOG.md | 1 + nitrocli/src/commands.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/nitrocli/CHANGELOG.md b/nitrocli/CHANGELOG.md index e7c1437..da44c4a 100644 --- a/nitrocli/CHANGELOG.md +++ b/nitrocli/CHANGELOG.md @@ -6,6 +6,7 @@ Unreleased - Added the `-f`/`--format` option for the `otp set` subcommand to choose the secret format - Deprecated the `--ascii` option +- Format `nitrokey` reported errors in more user-friendly format - Bumped `nitrokey` dependency to `0.3.1` diff --git a/nitrocli/src/commands.rs b/nitrocli/src/commands.rs index c86f20b..a5600b1 100644 --- a/nitrocli/src/commands.rs +++ b/nitrocli/src/commands.rs @@ -35,7 +35,7 @@ use crate::Result; /// Create an `error::Error` with an error message of the format `msg: err`. fn get_error(msg: &str, err: nitrokey::CommandError) -> Error { - Error::Error(format!("{}: {:?}", msg, err)) + Error::Error(format!("{}: {}", msg, err)) } /// Set `libnitrokey`'s log level based on the execution context's verbosity. -- cgit v1.2.1