From 686f61b75055ecb02baf9d9449525ae447a3bed1 Mon Sep 17 00:00:00 2001 From: Daniel Mueller Date: Tue, 1 Jan 2019 19:07:10 -0800 Subject: Adjust clippy target in Gitlab CI The clippy target as executed by the Gitlab CI excludes a bunch of lints when performing an initial run. That is necessary because some of the source code we rely on violates those rules and would cause the target to fail. The problem with the approach taken is that we list all the individual failing lints, which quickly becomes a maintenance burden. As it turns out clippy has the clippy::all meta-lint that subsumes all of the explicitly specified ones and so with this change we use that instead. --- nitrocli/ci/gitlab-ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/nitrocli/ci/gitlab-ci.yml b/nitrocli/ci/gitlab-ci.yml index b4ec21a..0b98522 100644 --- a/nitrocli/ci/gitlab-ci.yml +++ b/nitrocli/ci/gitlab-ci.yml @@ -23,8 +23,7 @@ lint:clippy: # nitrocli (everything else is still up-to-date). That procedure is # necessary because consumed dependencies may emit errors otherwise. - cd nitrocli - - cargo clippy --all-targets --all-features -- - -A warnings -A clippy::float_cmp -A clippy::cast_ptr_alignment -A clippy::unused_io_amount + - cargo clippy --all-targets --all-features -- -A clippy::all - cargo clean --package=nitrocli - cargo clippy --all-targets --all-features -- -D warnings -- cgit v1.2.3