A command line tool for interacting with Nitrokey devices (GitHub mirror) https://git.ireas.org/mirrors/nitrocli/atom?h=v0.3.3 2020-04-11T22:00:06Z 2020-04-11T22:00:06Z Daniel Mueller deso@posteo.net 2020-04-11T22:00:06Z urn:sha1:f2ace56200f0229a4dcbd1767f48a39e1daa343d We have never been fully satisfied with the name arg_defs. Now that we have gotten rid of the formerly used args module, this change renames arg_defs to args. 2020-04-11T20:23:52Z Daniel Mueller deso@posteo.net 2020-04-11T20:23:52Z urn:sha1:fafbf4a1bf635d5eea049cf561fbf8aa293c8e2b This change removes the args module by moving all remaining functionality in it into main.rs. The result is arguably a nice consolidation of all context related definitions in a single module. 2020-04-11T19:29:22Z Daniel Mueller deso@posteo.net 2020-04-11T19:29:22Z urn:sha1:93c605418568bf71bcc3be6956f07f9650b45fea As a next step moving us closer towards removing the args module, this change merges the config_set function into the existing function of the same name in the commands module. 2020-04-10T19:20:18Z Daniel Mueller deso@posteo.net 2020-04-10T19:20:18Z urn:sha1:eae8b2a1f0d1faf70776fccc12c93267a2143021 Now that we have isolated and separated out structopt specific definitions into a new module, arg_defs, args.rs is actually so small that we do not want to keep it around any longer. This change marks a first step moving us closer towards removing it. Specifically, it merges the otp_set function from args.rs into the function of the same name in commands.rs. 2020-04-04T17:44:29Z Daniel Mueller deso@posteo.net 2020-04-04T17:44:29Z urn:sha1:c0ae9e64695b44d372657e1a6521145bde5498d3 We are aiming to rid the arg_defs module of dependencies to the rest of the crate in an attempt to make the file fully free standing. The last remaining references into the crate are used to hook up the functionality backing the respective commands. Luckily for us, this "gluing" of functionality to types is really only required in the macro-generated code (which we do not care about as part of this exercise) and so with this change we remove the use declarations from the top of the file and reference the respective functionality in an absolute manner instead. 2020-04-04T17:38:24Z Daniel Mueller deso@posteo.net 2020-04-04T17:38:24Z urn:sha1:83d3e90248e9995e6c37c314b10597bccd394341 This change removes the need to import crate::Error from the arg_defs module. By dropping this dependency we make the file more independent of the rest of the crate, which subsequently will allow us to merely include! it in another file in order to get the argument related type definitions without compilation errors due to missing symbols from the rest of the crate. 2020-04-02T15:52:45Z Daniel Mueller deso@posteo.net 2020-04-02T15:52:45Z urn:sha1:eab4b20d16760043a1ec4d80d2e239fc1559bb2f The PinType struct, despite being intended for the pinentry module, is ultimately part of the argument handling definitions. Because our goal is to consolidate all of those in a single file, this change moves the definition of this type from the pinentry module into the newly introduced arg_defs. 2020-04-02T05:59:22Z Daniel Mueller deso@posteo.net 2020-04-02T05:59:22Z urn:sha1:a3f8ae474d153048c5a9252125099ef49cc6b5f4 This change marks the first step in a restructuring of the argument handling code, the ultimate goal of which is a separation of the type definitions as used by structopt from the logic associated with it. This change in particular introduces a new module, arg_defs, that contains all those type definitions that previously resided in the args module. 2020-03-23T00:05:32Z Daniel Mueller deso@posteo.net 2020-03-23T00:05:32Z urn:sha1:fd3fc6dc8945b4f9b30e9e8aed6d1341b51bfea8 The plugin_as_library lint has been deprecated as of Rust 1.40.0. Hence, with this change we remove it from the list of lints we want to get warnings from. 2020-01-29T11:25:33Z Robin Krahl robin.krahl@ireas.org 2020-01-29T11:25:33Z urn:sha1:bab33d84078a0ff2eb3d55ef39ea382b797abc92 nitrokey 0.6.0 introduced the SerialNumber struct (instead of representing serial numbers as strings). We no longer have to manually format the serial number as SerialNumber implements Display.