A command line tool for interacting with Nitrokey devices (GitHub mirror) https://git.ireas.org/mirrors/nitrocli/atom?h=master 2020-09-30T03:31:50Z 2020-09-30T03:31:50Z Daniel Mueller deso@posteo.net 2020-09-30T03:31:50Z urn:sha1:1af85ad50523427384234313fe00aa8bfa89135f When we originally switched over to using anyhow for error handling, we evidently missed to take advantage of its context support in a couple of error paths. The result was that we ended up with rather long winded > result.ok_or_else(|| anyhow::anyhow!(...)) constructs. This change shortens them, making use of the anyhow::Context trait. 2021-01-11T01:37:57Z Robin Krahl robin.krahl@ireas.org 2020-09-09T11:03:44Z urn:sha1:b39663bf381cbc1079fed08fbd3d0fe665151e90 For consistency with the --usb-path option, this path renames the device path column in the output of the list command to USB path. 2021-01-11T01:37:57Z Robin Krahl robin.krahl@ireas.org 2020-09-08T16:23:30Z urn:sha1:9593dfd03a6ca085d649ca090b6ec5e5f0104e78 This patch adds the --usb-path option as an additional way to filter the Nitrokey device to connect to. While the serial number is a better identifier in theory, the Nitrokey Storage devices do not send their serial number in the USB device descriptor. Having the --usb-path options allows users to select one of multiple Nitrokey Storage devices. While we could directly call the nitrokey::Manager::connect_path function with the specified path, we integrate the --usb-path option into the existing find_device function for consistent error messages and to avoid having to duplicate the --model and --serial-number checks. 2021-01-11T01:37:56Z Robin Krahl robin.krahl@ireas.org 2020-09-07T18:47:41Z urn:sha1:9975f8810399d5e535f2e2fd62b4dc56b313f955 This patch adds test cases for the new connection logic: - connect_multiple checks that nitrocli aborts if more than one Nitrokey device is connected and no filter is set. - connect_serial_number checks that we can use the --serial-number option to connect to all supported Nitrokey devices. - connect_wrong_serial_number checks that nitrocli aborts if it can’t find a device with the requested serial number. - connect_model checks that we can use the --model option to select the Nitrokey device to connect to, and that nitrocli aborts if it finds no matching device or multiple matching devices. 2021-01-11T01:37:56Z Robin Krahl robin.krahl@ireas.org 2020-01-25T19:33:57Z urn:sha1:6ce6dc4f3db67c3f6b6148b1fb03644e91900291 This patch adds the --serial-number option that allows the user to filter the attached Nitrokey devices by serial number. As the Nitrokey Storage does not include its serial number in the USB device descriptor and as we don't want to connect to it just to query the serial number, this option only works for Nitrokey Storage devices. 2021-01-11T01:37:55Z Robin Krahl robin.krahl@ireas.org 2020-09-06T21:44:18Z urn:sha1:6f029e744abc0f6d4cfe756d7e6b771be1be3999 Previously, we just applied our filter (if any) to all attached Nitrokey devices and selected the first match when connection to a Nitrokey device. This may lead to unexpected behavior if multiple devices are attached. This patch changes the find_device function to return an error if multiple matching devices are found. 2021-01-11T01:37:55Z Robin Krahl robin.krahl@ireas.org 2020-01-25T20:07:07Z urn:sha1:0f163477f63d533f90b61c1f39423712567bf7ea This patch introduces two new functions, find_device and connect, to connect to a Nitrokey device. find_device queries the attached Nitrokey devices, applies the filters (currently only the --model option) and returns the first match. connect calls find_device and connects to the returned device. This refactoring allows us to add more device filters, for example a --serial-number option, without code duplication. 2020-08-25T01:04:20Z Daniel Mueller deso@posteo.net 2020-08-25T01:04:20Z urn:sha1:0cc4371d138d5e98cd22813f10689cb089eef378 In the future we would like to provide more ways for tests to create a Nitrocli instance. In order to prevent explosion of with_XXX methods for each possible combination of arguments, this change allows for an easier configuration of an existing object with builder-pattern-inspired modifier methods. 2020-09-05T13:14:38Z Daniel Mueller deso@posteo.net 2020-09-05T13:14:38Z urn:sha1:24250081fe899b2f4ddfcf1fffc812e8c5e7b83e While the Nitrocli::model() method was well intentioned, we do not actually need it because we create a Nitrocli instance from the model passed to the individual test. We can just reuse this model instead. With this patch we do exactly that, allowing us to get rid of Nitrocli::model() all together. 2020-09-03T04:40:32Z Daniel Mueller deso@posteo.net 2020-09-03T04:40:32Z urn:sha1:79346022d01a73a8987298d82a2f0b749b63ac50 With this change we switch to using a REUSE compliant way of specifying the copyright & license of the program. To be fully in conformance we also add additional license specifications for the remaining files in the project. Lastly, a new CI pipeline rule takes care of verifying compliance on an ongoing basis.