mirrors/nitrocli, branch topic/gentoo-packaging

Describe steps for upstreaming a Gentoo ebuild

2018-12-31T22:05:20Z

UNFINISHED! Update with remaining step on next release.

Document known problems on macOS

2019-01-14T03:52:21Z

This change adds a new section briefly elaborating on the problem of using the program on macOS and details a possible solution.

Update nitrokey crate to 0.3.2

2019-01-12T21:24:21Z

This change updates the nitrokey crate to version 0.3.2. Import subrepo nitrokey/:nitrokey at 6ea73f29daa5db0215663a0a38334b764863671d

Update nitrokey-sys crate to 3.4.3

2019-01-12T21:09:49Z

This change updates the nitrokey-sys crate to version 3.4.3. Import subrepo nitrokey-sys/:nitrokey-sys at fe86df47853718983e1f45d6a4289a1d93ace45c

Use [patch] section to control local crate replacements

2019-01-06T22:17:31Z

The nitrokey-sys crate poses a challenge in that upgrading it causes build errors caused by linking against the system's nitrokey library from multiple crates, which is not allowed. The exact cause of the problem is unclear but the suspicion is that a bug in Cargo's replacing logic is the cause of the issue. To work around this problem, this change switches to using the [patch] section for replacing crates with local copies instead of the [replace] one.

Do not intermix path and replace attributes in Cargo.toml

2019-01-06T17:02:10Z

With the first usage of the nitrokey crate we have used the dependency's path attribute to perform the replacement with a local version of the source code, while most other dependencies are replaced using the [replace] section. Because the [replace] section is more flexible (it allows for replacement of transitive dependencies), this change unifies all dependencies to use it.

Properly flush stdout before process exit

2019-01-12T19:41:52Z

We exit the program using the process::exit function. This function just exits the program directly, without any cleanup. That can be a problem because IO buffers may not be flushed either. For a (typically) line buffered entity like stdout that may result in data not terminated by a newline symbol being not displayed properly. This change explicitly flushes stdout before exiting the process to alleviate this problem. Note that stderr output is unaffected, because stderr is not buffered by design.

Isolate cached PINs for multiple devices from each other

2019-01-12T03:45:59Z

The application supports multiple devices both plugged in at the same time as well as when used after the other. However, the GPG cache ID we use for storing and retrieving the respective PIN is effectively a constant. This constraint can cause problems when devices have different PINs, as the PIN of a previously plugged in device may be reused for an operation on a different one. To resolve this problem this change adds the respective device's model and serial number to the cache ID. As each serial number is supposed to be different, this will ensure that the correct PIN is used for each device. With this change we also show the model and serial number of the currently used device in the pinentry dialog. Note that because we do not store the serial numbers of all previously plugged in devices, the pin clear command will only clear the PIN for the currently plugged in device. If a user wants to make sure that a cached PIN is cleared, the pin clear command should be invoked before unplugging the device.

Remove unused fmt::Display implementation for PinType

2019-01-11T18:38:18Z

The implementation of the fmt::Display trait for the PinType is seemingly unused. Remove it.

Implement From<&str> for Error

2019-01-14T03:43:38Z

This patch implements From<&str> for Error so that we can use Error::from(s) as a shorthand for Error::Error(s.to_string()). It also replaces Error::Error with Error::from where possible.