libnitrokey/unittest, branch wip/multiple-devices

Add test for NK_list_devices to test_multiple_devices

2019-01-13T12:27:59Z

As we cannot test this function properly in Python (due to missing struct definitions), we test it in the C++ test suite.

Add test for NK_connect_with_path

2019-01-13T12:27:52Z

As we cannot read the output of NK_list_devices in the Python tests at the moment, this test case uses NK_list_devices_by_cpuID instead.

Add simple test for NK_list_devices

2019-01-13T12:27:45Z

Unfortunately, I cannot test more as the current ffi implementation does not allow me to import struct definitions. Without the definition for the NK_device_info struct, I cannot inspect the result of the NK_list_devices function.

Change std::wstring to std::string in DeviceInfo

2019-01-13T12:27:31Z

For easier handling, we should use a std::string instead of std::wstring for the serial number in DeviceInfo. For the conversion, I assume that the serial number is valid UTF-8. As it should be alphanumeric and ASCII only, this should be true.

Add test case for NitrokeyManager::connect_with_path to test_multiple_devices

2019-01-13T12:27:18Z

The current test case is renamed to “Use Storage API” as it queries the storage status. The new test case, “Use API”, lists all connected devices and prints their model, path and serial number.

Add test case for Device::enumerate to test_multiple_devices

2019-01-13T12:27:05Z

The current test case is renamed to “List Storage devices” as it also displays the SD card ID. The new test case, “List devices”, lists all connected devices and prints their model, path and serial number.

Make Device::enumerate static

2019-01-13T12:26:12Z

Device::enumerate does not need any instance data, therefore it is made static. Note that this not only changes the public API by making the method static. We also return all connected Nitrokey devices instead of only Storage devices. The NitrokeyManager method list_devices_by_cpuID is changed to check the device type so that they still only return Storage devices. The list_device method now returns both Storage and Pro devices.

Change Nitrokey::list_devices return type to use DeviceInfo

2019-01-13T11:03:43Z

In the previous commit, we changed the return value of Device::enumerate to std::vector. Now we change Nitrokey::list_devices to also return DeviceInfo instances.

Change Device::enumerate return type to use DeviceInfo

2019-01-13T11:03:34Z

The return type of Device::enumerate is changed from std::vector to std::vector to expose the additional information contained in the DeviceInfo struct.

Mention potential test failure cause, when no git version is provided

2019-01-02T12:35:01Z

Related to #133 Signed-off-by: Szczepan Zalega