From c61360fea0357672d2ab84a2c5a41ae1569f5d8a Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Sat, 27 Oct 2007 13:50:18 +0200 Subject: cgit_parse_commit(): Add missing call to xstrdup() It's rather silly to point into random memory-locations. Also, remove a call to strdup() used on a literal char *. Signed-off-by: Lars Hjemli --- parsing.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'parsing.c') diff --git a/parsing.c b/parsing.c index ddbafd5..30e7648 100644 --- a/parsing.c +++ b/parsing.c @@ -242,14 +242,14 @@ struct commitinfo *cgit_parse_commit(struct commit *commit) t = strchr(p, '\n'); if (t) { if (*t == '\0') - ret->subject = strdup("** empty **"); + ret->subject = "** empty **"; else ret->subject = substr(p, t); p = t + 1; while (*p == '\n') p = strchr(p, '\n') + 1; - ret->msg = p; + ret->msg = xstrdup(p); } else ret->subject = substr(p, p+strlen(p)); -- cgit v1.2.1