From 1bbe04c2c09d5dfbb2c66c4f8f490008b6e5fb25 Mon Sep 17 00:00:00 2001 From: Stefan Bühler Date: Sun, 16 Aug 2009 19:35:18 +0200 Subject: ui-refs.c: improve handling of lightweight tags MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a lightweight tag is referencing a commit object, cgit now uses the commit date when comparing tag age. Also, the commitdate and author info is printed in the refs view, making lightweight tags appear similar to annotated tags. Signed-off-by: Stefan Bühler Signed-off-by: Lars Hjemli --- ui-refs.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/ui-refs.c b/ui-refs.c index 25da00a..d3b4f6e 100644 --- a/ui-refs.c +++ b/ui-refs.c @@ -46,8 +46,19 @@ static int cmp_tag_age(const void *a, const void *b) { struct refinfo *r1 = *(struct refinfo **)a; struct refinfo *r2 = *(struct refinfo **)b; + int r1date, r2date; - return cmp_age(r1->tag->tagger_date, r2->tag->tagger_date); + if (r1->object->type != OBJ_COMMIT) + r1date = r1->tag->tagger_date; + else + r1date = r1->commit->committer_date; + + if (r2->object->type != OBJ_COMMIT) + r2date = r2->tag->tagger_date; + else + r2date = r2->commit->committer_date; + + return cmp_age(r1date, r2date); } static int print_branch(struct refinfo *ref) @@ -145,6 +156,12 @@ static int print_tag(struct refinfo *ref) print_tag_downloads(ctx.repo, name); else cgit_object_link(ref->object); + html(""); + if (ref->object->type == OBJ_COMMIT) + html(ref->commit->author); + html(""); + if (ref->object->type == OBJ_COMMIT) + cgit_print_age(ref->commit->commit->date, -1, NULL); html("\n"); } return 0; -- cgit v1.2.3